Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH and allow duplicate PUSH_PROMISE (#3309)
Ryan Hamilton <notifications@github.com> Mon, 06 January 2020 18:24 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D3A281200FD for <quic-issues@ietfa.amsl.com>; Mon, 6 Jan 2020 10:24:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 89ZZKw_MDPXb for <quic-issues@ietfa.amsl.com>; Mon, 6 Jan 2020 10:24:48 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 04A941200FB for <quic-issues@ietf.org>; Mon, 6 Jan 2020 10:24:48 -0800 (PST)
Date: Mon, 06 Jan 2020 10:24:47 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1578335087; bh=cUEuh5dqWr/ODjX2rTbHhz0a4iIV5X5uUI/M0YXuE7U=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=JL0w5DTuPbE7/zPtQcAmhG7UgyoMVUmfarXWDKE943eXTI6443lgDljD/1MXSoonj vN4yGD1h010kMCyJxQ6iJuPXC5mXGUTchZNIg73Zit4BzTuTi7OK2UKk+ArbyNiy1r oVQqf5GxkoESSFpdhbLcUwEdmLHQiDivNEZu9C2Q=
From: Ryan Hamilton <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZZSH2O5MIERNEIL3V4ECW67EVBNHHCAQAPGY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3309/review/338806325@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3309@github.com>
References: <quicwg/base-drafts/pull/3309@github.com>
Subject: Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH and allow duplicate PUSH_PROMISE (#3309)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e137b6f54295_e713fda7b2cd9641064a4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: RyanAtGoogle
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/6Y3grF5TMMvT_5D1WJKUtsaxWB8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Jan 2020 18:24:50 -0000
RyanAtGoogle commented on this pull request. > @@ -1238,9 +1233,10 @@ MAX_PUSH_ID frame ({{frame-max-push-id}}). A client MUST treat receipt of a PUSH_PROMISE frame that contains a larger Push ID than the client has advertised as a connection error of H3_ID_ERROR. -A server MUST NOT use the same Push ID in multiple PUSH_PROMISE frames. A client -MUST treat receipt of a Push ID which has already been promised as a connection -error of type H3_ID_ERROR. +A server MAY use the same Push ID in multiple PUSH_PROMISE frames. If so, the +decompressed request headers MUST be idential. A client MUST treat receipt of a +Push ID which has already been promised with different headers than the previous +promise as a connection error of type H3_ID_ERROR. I've updated the text to use the "MUST error if mismatch detected" language. > @@ -603,11 +602,11 @@ client making the indicated request. This trades off network usage against a potential latency gain. HTTP/3 server push is similar to what is described in HTTP/2 {{!HTTP2}}, but uses different mechanisms. -Each server push is identified by a unique Push ID. This Push ID is used in a -single PUSH_PROMISE frame (see {{frame-push-promise}}) which carries the request -headers, possibly included in one or more DUPLICATE_PUSH frames (see -{{frame-duplicate-push}}), then included with the push stream which ultimately -fulfills those promises. +Each server push is identified by a unique Push ID. This Push ID is used in one +or more PUSH_PROMISE frames (see {{frame-push-promise}}) that carry the request +headers, then included with the push stream which ultimately fulfills those +promises. When the same Push ID is promised on multiple request streams, the +decompressed request header fields MUST be byte-for-byte identical. Done. > -become available, or can initiate requests for discovered resources and cancel -the requests if the requested resource is already being pushed. When a client -receives a new push stream with an as-yet-unknown Push ID, both the associated -client request and the pushed request headers are unknown. The client can -buffer the stream data in expectation of the matching PUSH_PROMISE. The client -can use stream flow control (see section 4.1 of {{QUIC-TRANSPORT}}) to limit the -amount of data a server may commit to the pushed stream. +Due to reordering, push stream data can arrive before the corresponding +PUSH_PROMISE frame. When a client receives a new push stream with an +as-yet-unknown Push ID, both the associated client request and the pushed +request headers are unknown. The client can buffer the stream data in +expectation of the matching PUSH_PROMISE. The client can use stream flow control +(see section 4.1 of {{QUIC-TRANSPORT}}) to limit the amount of data a server may +commit to the pushed stream. + +If the same Push ID is promised on multiple request streams, the decompressed Done. > @@ -1238,9 +1233,10 @@ MAX_PUSH_ID frame ({{frame-max-push-id}}). A client MUST treat receipt of a PUSH_PROMISE frame that contains a larger Push ID than the client has advertised as a connection error of H3_ID_ERROR. -A server MUST NOT use the same Push ID in multiple PUSH_PROMISE frames. A client -MUST treat receipt of a Push ID which has already been promised as a connection -error of type H3_ID_ERROR. +A server MAY use the same Push ID in multiple PUSH_PROMISE frames. If so, the +decompressed request headers MUST be idential. A client MUST treat receipt of a Modified to include the same language as on line 605. Hope this helps! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3309#discussion_r363415764
- [quicwg/base-drafts] Remove DUPLICATE_PUSH and al… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… ianswett
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Lucas Pardue
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Lucas Pardue
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Kazuho Oku
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Mike Bishop
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Kazuho Oku
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Kazuho Oku
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Lucas Pardue
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Lucas Pardue
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Lucas Pardue
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Mike Bishop
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Kazuho Oku
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Jana Iyengar
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Lucas Pardue
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Mike Bishop
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Mike Bishop
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Lucas Pardue
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Mike Bishop
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Mike Bishop
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Mike Bishop
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Mike Bishop