Re: [quicwg/base-drafts] Import most H2 references (#3407)

"Roy T. Fielding" <notifications@github.com> Wed, 05 February 2020 14:51 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 770071200B3 for <quic-issues@ietfa.amsl.com>; Wed, 5 Feb 2020 06:51:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6ehpP-LKe7ue for <quic-issues@ietfa.amsl.com>; Wed, 5 Feb 2020 06:50:58 -0800 (PST)
Received: from out-14.smtp.github.com (out-14.smtp.github.com [192.30.254.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4BFCA120059 for <quic-issues@ietf.org>; Wed, 5 Feb 2020 06:50:58 -0800 (PST)
Date: Wed, 05 Feb 2020 06:50:57 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1580914257; bh=IHJISfjEoOm8IA9qKJ2g5IjgVUNUa4u9RMuCOQlxhdg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=swwY52Cw7SHve41v0Kl0quzBFswA2Y6GETunW3QzrlFiyboLIls/9LXnUUo5CZ2TE joU5lby7oapxX1YeVO0DgftbJE+DpiMbE2fUQmhBDW8XefwXLNQZEYDwgclTUpa7Lw IdN+bO45hgBE3ZucZJkUJT6J32FluOwTKiMXOvms=
From: "Roy T. Fielding" <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK75PV7ACJWB7D5ZOWF4JAENDEVBNHHCCW2GTU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3407/review/353775194@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3407@github.com>
References: <quicwg/base-drafts/pull/3407@github.com>
Subject: Re: [quicwg/base-drafts] Import most H2 references (#3407)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e3ad6516a64d_496b3fb8434cd96c129381"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: royfielding
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7d3CbAGs9vV5OGzLpFHJmrlWVeE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Feb 2020 14:51:01 -0000

royfielding commented on this pull request.



> @@ -552,10 +569,18 @@ an entire HTTP connection into a tunnel to a remote host. In HTTP/2, the CONNECT
 method is used to establish a tunnel over a single HTTP/2 stream to a remote
 host for similar purposes.
 
-A CONNECT request in HTTP/3 functions in the same manner as in HTTP/2. The
-request MUST be formatted as described in Section 8.3 of {{!HTTP2}}. A CONNECT
-request that does not conform to these restrictions is malformed (see
-{{malformed}}). The request stream MUST NOT be closed at the end of the request.
+A CONNECT request in HTTP/3 functions in the same manner as in HTTP/2.

I think it would be simpler for a reader to assume everything functions in the same manner as HTTP/2, and only note when it doesn't.  Likewise, this document defines HTTP/3, so no need to repeat that either. IOW, an editorial suggestion I would go with:

  `A CONNECT request MUST be constructed as follows:`

just to make it much easier to read.

Actually, I would begin the paragraph with a one-line description of the method from http-core Semantics, with a normative reference, like

`The CONNECT method requests that the recipient establish a tunnel to the destination origin server identified by the request-target (Section X.x of [ref:Semantics]).  A CONNECT request MUST be constructed as follows:`


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3407#pullrequestreview-353775194