Re: [quicwg/base-drafts] Import most H2 references (#3407)

ianswett <notifications@github.com> Sat, 15 February 2020 16:36 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 40E6A1200D7 for <quic-issues@ietfa.amsl.com>; Sat, 15 Feb 2020 08:36:34 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JxrBaZA6Nper for <quic-issues@ietfa.amsl.com>; Sat, 15 Feb 2020 08:36:32 -0800 (PST)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 48DD812008A for <quic-issues@ietf.org>; Sat, 15 Feb 2020 08:36:32 -0800 (PST)
Received: from github-lowworker-943b171.ac4-iad.github.net (github-lowworker-943b171.ac4-iad.github.net [10.52.22.59]) by smtp.github.com (Postfix) with ESMTP id 97C778C0328 for <quic-issues@ietf.org>; Sat, 15 Feb 2020 08:36:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1581784591; bh=hIcn4F1Aewf9dfJFxlqlMjC5FzY0LwXgYzHY0XtYTlc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=vjuUpcE+gMquU5VEqSHcrwfpp5dIglcYh51uBlEaKVGmggxVhMucV8dm4BP3qORlo O9JPt0Up2lva2oJ6dK5m95dyylNgW0mfMxrsePTbpwRMgJJVmrV3Us/++4OATIhS9n W7DIxuIlmVoBA79fTCpl5ldt1ohubfbURjFtFxEo=
Date: Sat, 15 Feb 2020 08:36:31 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3ZZ5IIJDVD4KPV6TV4KVII7EVBNHHCCW2GTU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3407/review/355346651@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3407@github.com>
References: <quicwg/base-drafts/pull/3407@github.com>
Subject: Re: [quicwg/base-drafts] Import most H2 references (#3407)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e481e0f85725_5f3b3fbd100cd96c896b3"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/e1Z4GAzYd5pMNhJPBeHM7QlwBvc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Feb 2020 16:36:34 -0000

ianswett approved this pull request.

Thanks for writing this.

> @@ -331,6 +331,11 @@ respective HTTP control stream (see {{control-streams}}).
 
 ## Connection Reuse
 
+HTTP/3 connections are persistent.  For best performance, it is expected that

I think "persistent across multiple requests." or something similar would be clearer.

>  Prior to making requests for an origin whose scheme is not "https," the client
 MUST ensure the server is willing to serve that scheme.  If the client intends
 to make requests for an origin whose scheme is "http", this means that it MUST
 obtain a valid `http-opportunistic` response for the origin as described in
 {{!RFC8164}} prior to making any such requests.  Other schemes might define
 other mechanisms.
 
+Servers are encouraged to maintain open connections for as long as possible but
+are permitted to terminate idle connections if necessary.  When either endpoint
+chooses to close the QUIC connection, the terminating endpoint SHOULD first send

Would "HTTP/3 session," make more sense than QUIC connection, given we're talking about an HTTP/3 layer GOAWAY?

>  those listed here.
 
+TODO:  This is going to be a big import, probably worthy of its own PR.

Leftover?  If not, I'm not sure what this TODO is exactly indicating.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3407#pullrequestreview-355346651