IETF Logo Mail Archive

Re: [quicwg/base-drafts] Only send one immediate ACK (#3361)

ianswett <notifications@github.com> Mon, 20 January 2020 19:48 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 97F2E1207FE for <quic-issues@ietfa.amsl.com>; Mon, 20 Jan 2020 11:48:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.382
X-Spam-Level:
X-Spam-Status: No, score=-1.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HneVVNSSU_HV for <quic-issues@ietfa.amsl.com>; Mon, 20 Jan 2020 11:48:08 -0800 (PST)
Received: from out-25.smtp.github.com (out-25.smtp.github.com [192.30.252.208]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 582F91200C4 for <quic-issues@ietf.org>; Mon, 20 Jan 2020 11:48:08 -0800 (PST)
Received: from github-lowworker-943b171.ac4-iad.github.net (github-lowworker-943b171.ac4-iad.github.net [10.52.22.59]) by smtp.github.com (Postfix) with ESMTP id 99BDB281184 for <quic-issues@ietf.org>; Mon, 20 Jan 2020 11:48:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579549687; bh=018x0fEBDHHMIAARWMVZmT8dPk8VLjfv+jBNaj5SzCo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=z2x0uZTfaObHPrwHhrhJu6GPRVCrQUrtsrHJqAInBhXs5B3vyu3rMGPRNq8isUyOW Lea4c928/QThtF+zyQKTrOWkpabXV6VLyFDR3hWt1X3qaq/ocOGqU0S4ef+L72qT/h t6jmn/7Jd7oNR0KCJc6lEkLBwZYWfI7tTz+QTMS0=
Date: Mon, 20 Jan 2020 11:48:07 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYB74M5NMQSBLUCDMN4GM3HPEVBNHHCBYLBH4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3361/review/345506384@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3361@github.com>
References: <quicwg/base-drafts/pull/3361@github.com>
Subject: Re: [quicwg/base-drafts] Only send one immediate ACK (#3361)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e2603f789f9f_27d13f8154ecd96024155a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/8NhxveGGxYQJQ09pYL0mC5zXr7w>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jan 2020 19:48:15 -0000

ianswett commented on this pull request.



> @@ -3136,12 +3136,10 @@ This recommendation is in keeping with standard practice for TCP {{?RFC5681}}.
 
 In order to assist loss detection at the sender, an endpoint SHOULD send an ACK
 frame immediately on receiving an ack-eliciting packet that is out of order. The

Yeah, I should have moved the definition from the recovery draft when the ACK text was moved.

I believe moving text is an editorial change, so how about I do that in a separate PR?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3361#discussion_r368704481

v2.23.0 | Report a Bug | By Email