IETF Logo Mail Archive

Re: [quicwg/base-drafts] Discard inconsistent packets (#2431)

MikkelFJ <notifications@github.com> Wed, 06 February 2019 21:35 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4CAC7130E62 for <quic-issues@ietfa.amsl.com>; Wed, 6 Feb 2019 13:35:28 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.552
X-Spam-Level:
X-Spam-Status: No, score=-12.552 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TQQFb7NQTkdE for <quic-issues@ietfa.amsl.com>; Wed, 6 Feb 2019 13:35:26 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9243F12D4F3 for <quic-issues@ietf.org>; Wed, 6 Feb 2019 13:35:26 -0800 (PST)
Date: Wed, 06 Feb 2019 13:35:25 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549488925; bh=EKP7WodlYwA/fL0eHveyeXBcJm0z3M/fvYn9cEVzHQI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=RcPKPDrYy72WqPEbHWahM/5owp16/eU8J1wqtJankvHOUdIdnOjYMJXTetGBBHd6a GcN7LFUl/kziyTlhmnCIU20DgoGXcZVUPJ9qX7pXFYVkipswcPePb00s0Nd0KE42vm PIgTK10m6Kk64999IBXMyihqZB+Li1/AGKY5bWAg=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4fade1157fec96c3b1648f2bbe67637269ec940992cf000000011873151d92a169ce18483443@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2431/review/200816939@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2431@github.com>
References: <quicwg/base-drafts/pull/2431@github.com>
Subject: Re: [quicwg/base-drafts] Discard inconsistent packets (#2431)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5b531d66e81_4fb63fb7df8d45c4429331"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/8qHwOcBgwjfZZ_7mF4zwwwJbkqo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Feb 2019 21:35:28 -0000

mikkelfj commented on this pull request.



> @@ -1010,8 +1010,10 @@ Endpoints can send a Stateless Reset ({{stateless-reset}}) for any packets that
 cannot be attributed to an existing connection. A stateless reset allows a peer
 to more quickly identify when a connection becomes unusable.
 
-Packets that are matched to an existing connection, but for which the endpoint
-cannot remove packet protection, are discarded.
+Packets that are matched to an existing connection are discarded if the packets
+are inconsistent with the state of that connection -- for example, if they
+indicate a different protocol version than that of the connection, or if the
+endpoint cannot remove packet protection.
 

During handshake, reordering can lead to temporarily undecryptable content which may be discarded or buffered. This is technically not inconsistent with state, but the above formulation could suggest to always drop such packets.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2431#pullrequestreview-200816939

v2.23.0 | Report a Bug | By Email