Re: [quicwg/base-drafts] Make congestion control more self-contained (#3463)

martinduke <notifications@github.com> Wed, 19 February 2020 20:22 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E7EA8120806 for <quic-issues@ietfa.amsl.com>; Wed, 19 Feb 2020 12:22:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iXKNMmwDlesD for <quic-issues@ietfa.amsl.com>; Wed, 19 Feb 2020 12:22:16 -0800 (PST)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3BB25120639 for <quic-issues@ietf.org>; Wed, 19 Feb 2020 12:22:16 -0800 (PST)
Received: from github-lowworker-28f8021.ac4-iad.github.net (github-lowworker-28f8021.ac4-iad.github.net [10.52.25.98]) by smtp.github.com (Postfix) with ESMTP id 687DA660A3D for <quic-issues@ietf.org>; Wed, 19 Feb 2020 12:22:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1582143735; bh=1OAAWlDEGjN/SxGkd2WzoZE5Z/EUmq2q+xMj6xXaf/w=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=DQJo4o7tOUZFgM+v17l3hBjSe7MSzW3iq5ROrlXKLwB8EYW9as5teSXnMuBJe71HB dc3VeMNA7N57eZjycXE6hW+CON6l9oowg9nVZD9cRlvCfjfpulrcYlHFM86MYZsJEp /SmDALTE4BlIUeBk/a9J9L9h2YNc9KIwTCR8dpvI=
Date: Wed, 19 Feb 2020 12:22:15 -0800
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7CO6ZJIOLF6AQMXYF4LLFXPEVBNHHCDOL7KI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3463/review/361397234@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3463@github.com>
References: <quicwg/base-drafts/pull/3463@github.com>
Subject: Re: [quicwg/base-drafts] Make congestion control more self-contained (#3463)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e4d98f756d6c_278f3ff03d0cd95c7159"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/9NabycAaQda-P7xwWBr1xrmBC1w>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Feb 2020 20:22:18 -0000

martinduke approved this pull request.



> @@ -661,19 +662,27 @@ receives packets with the Congestion Experienced codepoint.
 
 ## Slow Start
 
-QUIC begins every connection in slow start and exits slow start upon loss or
-upon increase in the ECN-CE counter. QUIC re-enters slow start any time the
-congestion window is less than ssthresh, which only occurs after persistent
-congestion is declared. While in slow start, QUIC increases the congestion
-window by the number of bytes acknowledged when each acknowledgment is
-processed.
+QUIC begins every connection in slow start with the congestion window set to
+an initial value.  The RECOMMENDED initial value is the minimum of
+10 * max_datagram_size and max(2 * max_datagram_size, 14720)).  This follows
+the analysis and recommendations in {{?RFC6928}}, increasing the byte limit to

The justification is repeated in Appendix B.1. I like it better here, but maybe make B.1 more concise and just point to here?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3463#pullrequestreview-361397234