Re: [quicwg/base-drafts] the crypto timeout is based on the last crypto packet sent (#2456)

ianswett <notifications@github.com> Wed, 13 February 2019 21:12 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7FA1E12E7C1 for <quic-issues@ietfa.amsl.com>; Wed, 13 Feb 2019 13:12:58 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.597
X-Spam-Level:
X-Spam-Status: No, score=-1.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QSJNE-0httAz for <quic-issues@ietfa.amsl.com>; Wed, 13 Feb 2019 13:12:56 -0800 (PST)
Received: from o3.sgmail.github.com (o3.sgmail.github.com [192.254.112.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C807C1200B3 for <quic-issues@ietf.org>; Wed, 13 Feb 2019 13:12:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=krjUJ2vNMjne7OSvMv27tg5/kn4=; b=rtKsadNZjglk2LDE Mp86wb9xlmeUeMmJZ2N3/uZByOTdJojO1EaHTNQ9gchmpC749Thjplgxg5Wn+vMi nKi/6t02dwV6BmeswW7i7CTCNl++9D7LbM/W0iwiLY13YiNzj6Mhb5ZF84SMwyJx o33Bx4ujG3dTlpLGGbcCRbD4OWE=
Received: by filter0854p1las1.sendgrid.net with SMTP id filter0854p1las1-14056-5C648857-32 2019-02-13 21:12:55.769882853 +0000 UTC m=+421947.123246886
Received: from github-lowworker-5909e27.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0034p1iad2.sendgrid.net (SG) with ESMTP id _rEdEsenQ6mJqJIvXyztnA for <quic-issues@ietf.org>; Wed, 13 Feb 2019 21:12:55.648 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-5909e27.cp1-iad.github.net (Postfix) with ESMTP id 9A2FB3E09DE for <quic-issues@ietf.org>; Wed, 13 Feb 2019 13:12:55 -0800 (PST)
Date: Wed, 13 Feb 2019 21:12:56 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab1f9bba6d6549f13b24f1bb7d361a7ceb6f0efcc892cf00000001187c4a5792a169ce1861ef0c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2456/review/203449583@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2456@github.com>
References: <quicwg/base-drafts/pull/2456@github.com>
Subject: Re: [quicwg/base-drafts] the crypto timeout is based on the last crypto packet sent (#2456)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c64885796fb4_3c663ff3f56d45c41307a9"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1445uAX0QCoympICQ8mRJIgCnjSrvqlol1/J GfMCXzHhLW6w9T1/VDSJfV7K8NadwO+UP3QO3vM8n/3oSYsSnmRhpNycV2BTDp45sv4ny0Q8sZv2bo 7t91JHHjVt0bl+5xPPMIwUL/fj6vcBnuOJ1wr1Q1k1XbJWKH52DB+Aiewo5lY5Z76EtSg/O7CWacaR E=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/BO1Z-VtCOISd0IoxPS38nVdCf38>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Feb 2019 21:12:58 -0000

ianswett commented on this pull request.



> @@ -412,7 +412,7 @@ is available, or if the network changes, the initial RTT SHOULD be set to 100ms.
 When an acknowledgement is received, a new RTT is computed and the timer
 SHOULD be set for twice the newly computed smoothed RTT.
 
-When crypto packets are sent, the sender MUST set a timer for the crypto
+Every time a crypto packet is sent, the sender MUST set a timer for the crypto

@mikkelfj is this suggestion about a different paragraph?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2456#discussion_r256590875