IETF Logo Mail Archive

Re: [quicwg/base-drafts] the crypto timeout is based on the last crypto packet sent (#2456)

ianswett <notifications@github.com> Tue, 12 February 2019 18:46 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6BADA130DE7 for <quic-issues@ietfa.amsl.com>; Tue, 12 Feb 2019 10:46:48 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.597
X-Spam-Level:
X-Spam-Status: No, score=-1.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ghKShFcDJHV1 for <quic-issues@ietfa.amsl.com>; Tue, 12 Feb 2019 10:46:45 -0800 (PST)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A88FB130DC4 for <quic-issues@ietf.org>; Tue, 12 Feb 2019 10:46:45 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=xwupSqkJv8tkhRxTY3eehh/H8kY=; b=C2eNEziIBl1tk9je 3MhoXYgPp1n4fNwJD5aJAgOuCbWksRz5HQQNUDX2Wi/fAWcZK7ZU45fLsravjES4 6wYaIk3ySBuA3rx/nYbX9RF3e2u/4tFIrUQuM+fnnBSlMS+Z5nHGOa/PXZ0SdZfR rXMNTE5JaKZBObbWVcp/RNrk/VM=
Received: by filter0838p1las1.sendgrid.net with SMTP id filter0838p1las1-29246-5C631494-D 2019-02-12 18:46:44.287579753 +0000 UTC m=+225856.524331287
Received: from github-lowworker-3c598a3.cp1-iad.github.net (unknown [192.30.252.43]) by ismtpd0009p1iad2.sendgrid.net (SG) with ESMTP id 9du8myF8QsayNioH1ccAsA for <quic-issues@ietf.org>; Tue, 12 Feb 2019 18:46:44.188 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-3c598a3.cp1-iad.github.net (Postfix) with ESMTP id 286F7A802B3 for <quic-issues@ietf.org>; Tue, 12 Feb 2019 10:46:44 -0800 (PST)
Date: Tue, 12 Feb 2019 18:46:44 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7043c44c277aa11ef70fcaae454d241312e2119392cf00000001187ad69492a169ce1861ef0c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2456/review/202842476@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2456@github.com>
References: <quicwg/base-drafts/pull/2456@github.com>
Subject: Re: [quicwg/base-drafts] the crypto timeout is based on the last crypto packet sent (#2456)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c63149425c9c_53ca3fecee4d45c01712c1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak066aqoeiZNK0NGbFNy5peRYso4KXBwURboma NGeIriVBh5geeOqtm8FcVyS84U28qQ+4qsLyZuUrTn3t9NgkcK+MDXVfY7RNc7/IwAITcVSJEfoz4m n+XahLzjotDO0FJAzK43rl3VduepYesJr9HEhgjHSU7ZbJQBe9Us5g3ieQ==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/HI08ckH_aYgCZqVnB6FKpc2QVNQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Feb 2019 18:46:49 -0000

ianswett commented on this pull request.



> @@ -412,7 +412,7 @@ is available, or if the network changes, the initial RTT SHOULD be set to 100ms.
 When an acknowledgement is received, a new RTT is computed and the timer
 SHOULD be set for twice the newly computed smoothed RTT.
 
-When crypto packets are sent, the sender MUST set a timer for the crypto
+Every time a crypto packets is sent, the sender MUST set a timer for the crypto

I'm not sure this is significantly clearer, but I do understand what you're trying to address.

```suggestion
Every time a crypto packet is sent, the sender MUST set a timer for the crypto
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2456#pullrequestreview-202842476

v2.23.0 | Report a Bug | By Email