Re: [quicwg/base-drafts] DUPLICATE_PUSH instead of multiple PUSH_PROMISE frames (#2072)

Mike Bishop <notifications@github.com> Fri, 30 November 2018 00:02 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8F738128D68 for <quic-issues@ietfa.amsl.com>; Thu, 29 Nov 2018 16:02:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LtySpX1L35sV for <quic-issues@ietfa.amsl.com>; Thu, 29 Nov 2018 16:02:30 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0708C1286E7 for <quic-issues@ietf.org>; Thu, 29 Nov 2018 16:02:30 -0800 (PST)
Date: Thu, 29 Nov 2018 16:02:29 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543536149; bh=f2+4akJy5umcz1LIL8aviHvp2TCEU6Q4wo46CnESjS4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=bFbo8O8cSWupevNlaQIgBzMo+9ctsLHH7bu/vI+WYFnN2OZ9Ey3fIcq4wMErU8qrR o7ZP6/tacWnHa1tg8+0K3qv3852VfyN5NymhHCbrbVSz9tlgZdzNyGRdPzN7wADVNK qd8DrbiffaNEtVDOGKxSsSF0QyJokWGQWSbOV6sY=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4252f39970b36387d3a22b827e1aa4530e497f7692cf000000011818401592a169ce170109b9@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2072/review/180073185@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2072@github.com>
References: <quicwg/base-drafts/pull/2072@github.com>
Subject: Re: [quicwg/base-drafts] DUPLICATE_PUSH instead of multiple PUSH_PROMISE frames (#2072)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c007e152c59a_20c93fad680d45bc11999d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/COlJ_rWhphPMleByjxniESOVtaU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Nov 2018 00:02:31 -0000

MikeBishop commented on this pull request.



>  
-The PRIORITY frame {{frame-priority}} identifies a prioritized element. The
-elements which can be prioritized are:
+When a client request is first sent or a placeholder first allocated, the
+element is dependent on the root of the priority tree. Pushed streams are
+initially dependent on the client request on which the PUSH_PROMISE frame was
+sent. In all cases, elements are assigned an initial weight of 16.

Moved to #2074 so I could do more priority-related changes without blocking on this, but I agree.  :-)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2072#discussion_r237705507