Re: [quicwg/base-drafts] Remove EndOfEarlyData from TLS (#1792)

Kazuho Oku <notifications@github.com> Tue, 25 September 2018 18:07 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 06B2B128C65 for <quic-issues@ietfa.amsl.com>; Tue, 25 Sep 2018 11:07:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.455
X-Spam-Level:
X-Spam-Status: No, score=-3.455 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BTxs-vaUgZyr for <quic-issues@ietfa.amsl.com>; Tue, 25 Sep 2018 11:07:45 -0700 (PDT)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 743D3128B14 for <quic-issues@ietf.org>; Tue, 25 Sep 2018 11:07:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=56MlrzSVlUkfgH884XrWBeZPncg=; b=LKIWr9LSlWfBIMHs 7Fm5GfzlENpLdc+Mi/Xe0ou1aJSCPgVI47TV6YGUH/ep3uiadeD8LwxOBhw0lKFl ZqFWjaU5XQreFiDOc03kedD5GJkGn33eIPM9fNnC8NKgnPuMvRTd7mRYJLBcupw9 ph5dmZ2mRLahPhLHJu3Qt4D3Ndc=
Received: by filter1763p1mdw1.sendgrid.net with SMTP id filter1763p1mdw1-21221-5BAA793E-1A 2018-09-25 18:06:54.261190274 +0000 UTC m=+42.301278894
Received: from github-lowworker-dcd58f3.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0011p1iad2.sendgrid.net (SG) with ESMTP id zyLisNcRRu2HtUiEHJFf1w for <quic-issues@ietf.org>; Tue, 25 Sep 2018 18:06:54.224 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-dcd58f3.cp1-iad.github.net (Postfix) with ESMTP id 1D646240D6D for <quic-issues@ietf.org>; Tue, 25 Sep 2018 11:06:54 -0700 (PDT)
Date: Tue, 25 Sep 2018 18:06:54 +0000
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab39c25d300e2e2d19bba8402a3e25379255002cd092cf0000000117c23b3e92a169ce15a864f1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1792/review/158673698@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1792@github.com>
References: <quicwg/base-drafts/pull/1792@github.com>
Subject: Re: [quicwg/base-drafts] Remove EndOfEarlyData from TLS (#1792)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5baa793e1b08c_7623fc1bb2d45bc2069bd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3wqXUQ+gyAutEsrLIiWGk8hSQwNhBz6Tc7NN WlgkAeI8WEYWKpd34DnZVAxxAYsGy324+LRdXb94IdMcKaSGgCAr7iDVlYcHnCTD6MMdSu8svoX4tK yeXXv/UEWoK2iC+G7y9S+zey9tXQpBDWYxT+0HdRQahUVVInZt058uPmBRQbe6RRpvBoVGTiU4msz/ w=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/CXPMXSsq5VmH_QCJLp4Z1DatvcY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Sep 2018 18:07:48 -0000

kazuho commented on this pull request.



> @@ -1107,6 +1107,21 @@ of the handshake, they cannot be fully trusted until the handshake completes,
 and reliance on them should be minimized.  However, any tampering with the
 parameters will cause the handshake to fail.
 
+Endpoints MUST NOT send this extension in a TLS connection that does not use
+QUIC (such as the use of TLS with TCP defined in {{!TLS13}}).  A fatal
+unsupported_extension alert MUST be sent if this extension is received when the
+transport is not QUIC.
+
+
+## Removing the EndOfEarlyData Message {#remove-eoed}
+
+Negotiating the quic_transport_parameters extension also modifies TLS to remove
+the EndOfEarlyData message.  QUIC does not rely on this message to mark the end

My preference goes to simply stating that we do not use EOED in QUIC, rather than stating that the use of a particular extension signals the omission (I assume that is what @siyengar suggested).

My read is that the proposed text expects the stacks to be implemented in either of the following two ways, which seems like an unnecessary complication to me:
* making TLS stacks depend on an extension defined outside of TLS
* let the server-side QUIC stack modify the flag of the TLS stack (signaling the omission) when it processes ClientHello

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1792#pullrequestreview-158673698