Re: [quicwg/base-drafts] Packet number encryption (#1079)

Mike Bishop <notifications@github.com> Mon, 29 January 2018 22:24 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2EFEB126E3A for <quic-issues@ietfa.amsl.com>; Mon, 29 Jan 2018 14:24:05 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.028
X-Spam-Level:
X-Spam-Status: No, score=-2.028 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FFfGG2HAh4U3 for <quic-issues@ietfa.amsl.com>; Mon, 29 Jan 2018 14:24:03 -0800 (PST)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3F3811201F8 for <quic-issues@ietf.org>; Mon, 29 Jan 2018 14:24:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=qWC8XykwoOuV05DPjBOMOR5Gwhw=; b=XBIhloIbiym+I+pt CNcmoJCnAR5aFv5q8Sloguxfkxcgh7TdY5femR3QhgRF+8Go2Z+bw4Jf4qBYRnFx GwLVRDIfdstFEhreDrb4FCnxOuglQ03fEtnYp3hIOvCs+5R7Z3W6t6AamWOw859o r9m7l19EMG2mOq8U/r4PSoxJMHo=
Received: by filter0187p1las1.sendgrid.net with SMTP id filter0187p1las1-14517-5A6F9F01-36 2018-01-29 22:24:01.922394752 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id 07SYWMivRiCZHk7-wZ9oBw for <quic-issues@ietf.org>; Mon, 29 Jan 2018 22:24:02.062 +0000 (UTC)
Date: Mon, 29 Jan 2018 22:24:02 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3b9d83badc7b93c00f91ed45472de5766b9e086a92cf000000011687610192a169ce116c0848@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1079/review/92379830@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1079@github.com>
References: <quicwg/base-drafts/pull/1079@github.com>
Subject: Re: [quicwg/base-drafts] Packet number encryption (#1079)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5a6f9f01ebb93_76143fdf7db6ef301116f4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0Owe9U3j1esx1qwQEJqk7LLU/nlRxS2xdykS PTmdlORgLA2hyJT7ymDkJO3gwmpxFqjaIVBZ+1EutcO0d5OK2ArZ82SW2rNsRZglKBxAbFp9QeL1BL CU7jWvRQ+0wsJarNgxuFFsofhwbe8k/7YWV+in+smKrbNeq2WmGslqs975t684Rv/W12sMRsCVs/WL M=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Dwt9YSceUBJ2LjXzcCxCNP4AV-0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jan 2018 22:24:05 -0000

MikeBishop commented on this pull request.



> +## Packet Number Protection {#pn-encrypt}
+
+QUIC packets are protected using a key that is derived from the current set of
+secrets.  The key derived using the "pn" label is used to protect the packet
+number from casual observation.  The packet number protection algorithm depends
+on the negotiated AEAD.
+
+Packet number protection is applied after packet protection is applied (see
+{{aead}}).  The ciphertext of the packet is sampled and used as input to an
+encryption algorithm.  For packets with a long header, the ciphertext starting
+immediately after the packet number is used (that is, octet 17 onwards).  For
+packets with a short header, the packet number length is not known, so it is
+assumed to be its largest possible length (4 octets).  Thus, for a short header,
+the sampled ciphertext starts at either octet 5 when the connection ID is
+omitted, or octet 13 when the connection is present.
+

Perhaps a client-initiated PATH_CHALLENGE/PATH_RESPONSE should be long header packets?  But that's totally orthogonal to this PR, I think.  So long as the packet number is obscured in both header types, an observer can't tell whether a connection is restarting from zero or not.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1079#discussion_r164584157