IETF Logo Mail Archive

Re: [quicwg/base-drafts] Packet number encryption (#1079)

Martin Thomson <notifications@github.com> Thu, 03 May 2018 02:33 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3278612D77B for <quic-issues@ietfa.amsl.com>; Wed, 2 May 2018 19:33:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.008
X-Spam-Level:
X-Spam-Status: No, score=-8.008 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6DSQnRIveymd for <quic-issues@ietfa.amsl.com>; Wed, 2 May 2018 19:33:53 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 741A6127599 for <quic-issues@ietf.org>; Wed, 2 May 2018 19:33:53 -0700 (PDT)
Date: Wed, 02 May 2018 19:33:52 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1525314832; bh=LTQaj/aC6VaBc4Mmf8c/fUDFkMYjP5SLuwd+zDlxRbk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=mWifOt5JXN7Bq70r+IYsXRtb5BP+M8IWERB/V5CvDtHfmBo1d/yjj4TIybUb8lfV7 grY5xEEWqbczMMARgmPi4cD+zVKXsUBgKsUY9Pbs0tWaJaSUDAFLWqMyeuYyuaVun0 Ubop26pP164wRP0GquSNUjTGZTQ8Amvyph3OzRko=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab84d4b0c7ee794b99d0ce242ff6851abafa2011e692cf000000011702371092a169ce116c0848@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1079/review/117125556@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1079@github.com>
References: <quicwg/base-drafts/pull/1079@github.com>
Subject: Re: [quicwg/base-drafts] Packet number encryption (#1079)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aea7510916dd_78c22aaf47444f50856ec"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/MeO1EsgABD6am6qeLdkxdpl0oEc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 May 2018 02:33:55 -0000

martinthomson commented on this pull request.



> @@ -612,8 +614,11 @@ The server includes a connection ID of its choice in the Source Connection ID
 field.  The client MUST use this connection ID in the Destination Connection ID
 of subsequent packets that it sends.
 
-The packet number field echoes the packet number field from the triggering
-client packet.
+The Packet Number field of a Retry packet MUST be set to 0.  This value is
+subsequently protected as normal. \[\[Editor's Note: This isn't ideal, because
+it creates a "cheat" where the client assumes a value.  That's a problem, so I'm
+tempted to suggest that this include any value less than 2^30 so that normal
+processing works - and can be properly exercised.]]

The 0-length connection ID is only possible after the client has received a Retry, after which it will discard any Retry packets that it receives.  So I don't think so.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1079#discussion_r185687219

v2.46.0 | Report a Bug | By Email | System Status