IETF Logo Mail Archive

Re: [quicwg/base-drafts] protection-samples.js: add option to output ChaCha20-Poly1305 trace (#3506)

Martin Thomson <notifications@github.com> Wed, 11 March 2020 05:33 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0377F3A1215 for <quic-issues@ietfa.amsl.com>; Tue, 10 Mar 2020 22:33:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.482
X-Spam-Level:
X-Spam-Status: No, score=-1.482 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id coOofLYiPUYu for <quic-issues@ietfa.amsl.com>; Tue, 10 Mar 2020 22:33:33 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6E9803A1218 for <quic-issues@ietf.org>; Tue, 10 Mar 2020 22:33:33 -0700 (PDT)
Date: Tue, 10 Mar 2020 22:33:32 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1583904812; bh=xlgzTROhQ1P7Z7wrW5mnqJGtArrFfxOCd5hVnP0Snw0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=cBxgyndlrjzT2+EkbgjBOxUbzQKtLT8+8zGqfIIZnwiOzNqVnb/UQpOYVe5RHIUFh WpW911s+LJkSrKszW4YYLkaMyMbIyL+LlPhgntNFit+4Mh95jZjz0ulLCycAsTf+1B Et57407BogVRYp85rtVRc7H3w4O9kihRXxkCTl8o=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZWK3DQOLU5YQQV7EV4ORMSZEVBNHHCE65UIA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3506/c597451992@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3506@github.com>
References: <quicwg/base-drafts/pull/3506@github.com>
Subject: Re: [quicwg/base-drafts] protection-samples.js: add option to output ChaCha20-Poly1305 trace (#3506)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e68782c92b3d_205f3ffced6cd96c497140"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Fn_0NMY6d6_KQXaqBx7BxGgnMx4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Mar 2020 05:33:35 -0000

Hey Daiki,

Thanks for spending the time on this.  You've improved my terrible code a fair bit in the process.  Most of the refactoring is flat good and I want to take that.

However, I don't think that this is the right approach.  All the examples here are Initial or Retry packets, for which there is only one AEAD we use: AES-GCM.  What we really need is an example of another type of packet (maybe a 1-RTT packet with a short header) for a ChaCha example.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3506#issuecomment-597451992

v2.23.0 | Report a Bug | By Email