Re: [quicwg/base-drafts] Forbid duplicate setting identifiers. (#2979)

Mike Bishop <> Wed, 21 August 2019 14:46 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 6D970120271 for <>; Wed, 21 Aug 2019 07:46:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id cHz845nZOH2c for <>; Wed, 21 Aug 2019 07:46:35 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id A5D4112025D for <>; Wed, 21 Aug 2019 07:46:35 -0700 (PDT)
Date: Wed, 21 Aug 2019 07:46:34 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1566398794; bh=IVOHH7Tegw554enFxtu34Lr1OYgLgqqH2GEAjoa10mA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=S9ZGJr5oCvRrbt0yx0TRXPgN6zkhtDMEkHLbSEjMxPOJ8f+RYfpYmYUYuOy62V8Uz vjSWqgxe5oJD9MSeJNwl8JKSG+jNgWoZvooOnKX18MzoMQFQQo1fyVMTmsv497jQhf agnC23j5mluddXm5Isd9a7mAIYALcSJr5B1QBY1s=
From: Mike Bishop <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/2979/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Forbid duplicate setting identifiers. (#2979)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d5d594a888ea_393b3f8077ecd95c329349"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Wed, 21 Aug 2019 14:46:37 -0000

MikeBishop approved this pull request.

Looks fine to me, module the line length.

> @@ -1340,9 +1340,9 @@ Different values for the same parameter can be advertised by each peer. For
 example, a client might be willing to consume a very large response header,
 while servers are more cautious about request size.
-Parameters MUST NOT occur more than once in the SETTINGS frame.  A receiver MAY
-treat the presence of the same parameter more than once as a connection error of
+The same setting identifier MUST NOT occur more than once in the SETTINGS frame.  A

Need to rewrap to fix the build break, I think.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: