IETF Logo Mail Archive

Re: [quicwg/base-drafts] One Retry/VN per UDP datagram (#2303)

Kazuho Oku <notifications@github.com> Mon, 07 January 2019 01:31 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 47521130E85 for <quic-issues@ietfa.amsl.com>; Sun, 6 Jan 2019 17:31:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.661
X-Spam-Level:
X-Spam-Status: No, score=-6.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Fm2Pc9Q-ICaX for <quic-issues@ietfa.amsl.com>; Sun, 6 Jan 2019 17:31:33 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6491B129C6A for <quic-issues@ietf.org>; Sun, 6 Jan 2019 17:31:33 -0800 (PST)
Date: Sun, 06 Jan 2019 17:31:32 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546824692; bh=DNIwcfRVTP3lHQYnQ0vdPYcuE9IFJpzeXrdB4+sxVhM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=lHxzWBMszORXglQwl85hsoxoJ+WxSc5RKu+6H9PNSCrGN1nIjU4JkDZEgnQVtD++M pvgvYUyU0Y74tyek72BZetmY87hdnh/maGEiXs2hpwBav8SzxgQPN+HGoDO3lBhval KbFAVXP5QsFL7EEi5WwtDDYkfwVdbaDhypaPRJFY=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba4223cca9fb5c29adb98aa87c302b770273ded0d92cf00000001184a6df492a169ce179f536f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2303/review/189656542@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2303@github.com>
References: <quicwg/base-drafts/pull/2303@github.com>
Subject: Re: [quicwg/base-drafts] One Retry/VN per UDP datagram (#2303)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c32abf44b2a5_6393f86686d45c49744a9"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Gpy7qBagQqcGoHX38YFYajMlW8o>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jan 2019 01:31:35 -0000

kazuho requested changes on this pull request.



> @@ -3630,6 +3627,9 @@ The Version Negotiation packet does not include the Packet Number and Length
 fields present in other packets that use the long header form.  Consequently,
 a Version Negotiation packet consumes an entire UDP datagram.
 
+A server MUST NOT send more than one Version Negotiation packet in response to a
+single UDP datagram.

I believe this paragraph is the one you intend to add, and it looks fine to me.

OTOH I see lots of unrelated changes that essentially reverts the recently merged changes. Maybe you need to cherry-pick?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2303#pullrequestreview-189656542

v2.23.0 | Report a Bug | By Email