Re: [quicwg/base-drafts] Explicitly permit starting over (#1621)
ekr <notifications@github.com> Wed, 01 August 2018 02:12 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4FF8D130F24 for <quic-issues@ietfa.amsl.com>; Tue, 31 Jul 2018 19:12:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.109
X-Spam-Level:
X-Spam-Status: No, score=-6.109 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9lYpDxwwH1eq for <quic-issues@ietfa.amsl.com>; Tue, 31 Jul 2018 19:12:55 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3B311130F21 for <quic-issues@ietf.org>; Tue, 31 Jul 2018 19:12:55 -0700 (PDT)
Date: Tue, 31 Jul 2018 19:12:54 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1533089574; bh=23PXv3dcq9yUOQD+TzAA/1mt6CrDVqClgRcMhoG8W9I=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=PjGiztHNGklbwXXu+Ed6FVWQ0N22G2LjC4uo5yb9nMY/WH8XC9bjcwzgoCdoZ9CqX nV5MIU0/f9UCylRTF53IByPSLzJuerwlDFo4aRNk72yu3cklQ5Ds+AWuducU6zmuAi tBgX24EMCqjrcZcb3KT6JsgL4dsOMlMKFFVuDu+E=
From: ekr <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abc18184b4dfb3366209bb860b4959e3ec7ec5de7992cf000000011778d92692a169ce14a5c06e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1621/review/142206633@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1621@github.com>
References: <quicwg/base-drafts/pull/1621@github.com>
Subject: Re: [quicwg/base-drafts] Explicitly permit starting over (#1621)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b6117268b527_60053fe24b2d45c01337dd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ekr
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/HW-engNFpMUGP_casPHMJ1p9tQk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2018 02:12:57 -0000
ekr approved this pull request. Modulo comment, LGTM > @@ -806,7 +806,8 @@ A client MUST NOT reset the packet number it uses for 0-RTT packets. The keys used to protect 0-RTT packets will not change as a result of responding to a Retry or Version Negotiation packet unless the client also regenerates the cryptographic handshake message. Sending packets with the same packet number in -that case would compromise the packet protection for all 0-RTT packets. +that case could compromise the packet protection for all 0-RTT packets because Why the change from "would" to "could". Could seems a lot more likely. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1621#pullrequestreview-142206633
- Re: [quicwg/base-drafts] Explicitly permit starti… ekr
- [quicwg/base-drafts] Explicitly permit starting o… Martin Thomson
- Re: [quicwg/base-drafts] Explicitly permit starti… Martin Thomson
- Re: [quicwg/base-drafts] Explicitly permit starti… ianswett
- Re: [quicwg/base-drafts] Explicitly permit starti… Martin Thomson