IETF Logo Mail Archive

Re: [quicwg/base-drafts] PING is reliably delivered (#2068)

Martin Thomson <notifications@github.com> Thu, 29 November 2018 02:32 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9DFD3126CB6 for <quic-issues@ietfa.amsl.com>; Wed, 28 Nov 2018 18:32:54 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QYihamUPP-zy for <quic-issues@ietfa.amsl.com>; Wed, 28 Nov 2018 18:32:53 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3BCC7124BF6 for <quic-issues@ietf.org>; Wed, 28 Nov 2018 18:32:53 -0800 (PST)
Date: Wed, 28 Nov 2018 18:32:52 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543458772; bh=aN3LdGtC/mO6H2d0P+olZOvxnuWnOkwctVnvfoT2OUw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=vD68WjPX2njZukI1LMD3ZFHbizyAUDBPgwqRanUI6M4/VCx6CxYTVtZDH1yqI0uD3 jy2n5cuHe33Fw3VpZ7ZSUEvEtxOeWkMVf2o+fWXOXoA+cHNzhZEDgwVFveDeHtTXt2 i8rb6pZycBLfA5yePQJhfNq3xPDQIvqDEeZlCvzc=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf469be8cc3e0657e29e6c9bcf84f3ec7667f37a192cf00000001181711d492a169ce16fae0fe@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2068/review/179607307@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2068@github.com>
References: <quicwg/base-drafts/pull/2068@github.com>
Subject: Re: [quicwg/base-drafts] PING is reliably delivered (#2068)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bff4fd45a17c_3f8c3fcf32ad45bc2434dc"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/JPDBE4Vmq74i3R5AYWY0MCJqCjA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Nov 2018 02:32:55 -0000

martinthomson commented on this pull request.

It's acknowledged, but PING is curiously absent from the retransmission rules.

I don't think that we should assume that PING needs to be sent again if the packet containing it is lost.  The point of PING is to elicit acknowledgment.  Whether that is for a specific packet or just for the connection in general, it shouldn't matter to us.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2068#pullrequestreview-179607307

v2.23.0 | Report a Bug | By Email