Re: [quicwg/base-drafts] pto_count should be reset when dropping a packet number space (#3272)

Jana Iyengar <notifications@github.com> Sat, 23 November 2019 14:33 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2D20E120088 for <quic-issues@ietfa.amsl.com>; Sat, 23 Nov 2019 06:33:58 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SgytZ__j35Gg for <quic-issues@ietfa.amsl.com>; Sat, 23 Nov 2019 06:33:56 -0800 (PST)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AC748120043 for <quic-issues@ietf.org>; Sat, 23 Nov 2019 06:33:56 -0800 (PST)
Received: from github-lowworker-292e294.va3-iad.github.net (github-lowworker-292e294.va3-iad.github.net [10.48.102.70]) by smtp.github.com (Postfix) with ESMTP id A31C26A121E for <quic-issues@ietf.org>; Sat, 23 Nov 2019 06:33:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1574519635; bh=bSr7ePVZd8nu5gdNg6Q+AibuqIf56EE+bDd2B/FGfPk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=tdyI60wvg4ZLnZ4OcLaYMrWpcN5NnbaCSUQTrYnkwGaieou6okP2viSu39Gm1q3Zy 1EPeujFk8b5LIYD92xmBSifa39cLMcp1DQ4HHh1J5sleUwFuQ1e/8m6BJ9u0ZpDqBU S5jeZM2Ul44NESJjeXHFoSZY7OwNLnogucxB3cnE=
Date: Sat, 23 Nov 2019 06:33:55 -0800
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6NRY6IVWUKJRCSYO534Z25HEVBNHHB64N4FE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3272/557802728@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3272@github.com>
References: <quicwg/base-drafts/issues/3272@github.com>
Subject: Re: [quicwg/base-drafts] pto_count should be reset when dropping a packet number space (#3272)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dd9435393f93_a4a3f96a60cd95c299165"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/KYmkYnn0Xvz852eb82IHSCrTVOs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Nov 2019 14:33:58 -0000

I think this is alright. It should happen anyway, since receiving an ACK
should be the common case.

On Sat, Nov 23, 2019, 7:43 PM Marten Seemann <notifications@github.com>
wrote:

> pto_count should be reset to 0 when a packet number space is dropped. I'd
> argue that this is the consistent thing to do, because when we drop a
> packet number space, we implicitely acknowledge all outstanding packets in
> that space (and remove them from bytes_in_flight).
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/quicwg/base-drafts/issues/3272?email_source=notifications&email_token=ACUOBVDKY7DEHZVVBTYYM7TQVEJODA5CNFSM4JQZ2L6KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H3RXQUQ>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACUOBVBBCAAP2HEQKL55DRTQVEJODANCNFSM4JQZ2L6A>
> .
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3272#issuecomment-557802728