[quicwg/base-drafts] Clarify CANCEL_PUSH server send conditions (#3387)

BrianGithubber <notifications@github.com> Wed, 22 January 2020 22:25 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 448B2120108 for <quic-issues@ietfa.amsl.com>; Wed, 22 Jan 2020 14:25:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o5QkxpcEUQV2 for <quic-issues@ietfa.amsl.com>; Wed, 22 Jan 2020 14:25:28 -0800 (PST)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2255B120089 for <quic-issues@ietf.org>; Wed, 22 Jan 2020 14:25:28 -0800 (PST)
Date: Wed, 22 Jan 2020 14:25:27 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579731927; bh=7tJK7p9Zb3A0zBc2WQnZUPXr6jUI7dyBi6LOS3RlEzY=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=iaEhTVSQiMMduoiobGdvWvzGG0g/nnRQBYau8UulC+DaFruUTOd5fQbI8dR0KIT4/ oLSJnKoQ/sYpzW/z9YSAneqi8YlcV2JISA7m6JZRheBniwt6r/EdpHYIMZeD5C2Iau 6szgIZD/3r3ZPkffWfZfbQsFkpgUf3DJAHAKQgD8=
From: BrianGithubber <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3N2WSK5TW756CVUJV4GX7FPEVBNHHCCAWIWI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3387@github.com>
Subject: [quicwg/base-drafts] Clarify CANCEL_PUSH server send conditions (#3387)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e28cbd72c336_69433fac486cd96c9246d"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: BrianGithubber
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/KkbpQxqe0FUBKLtPhS7hdyyf2p4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jan 2020 22:25:31 -0000

The current draft (7.2.3) says:
A server SHOULD NOT send a CANCEL_PUSH when it has already created a corresponding push stream.

However, this is ambiguous.   In our implementation, at least, it is possible to create a push stream, but not have sent anything on that push stream yet.
If a failure happens while in this state, and we don’t send a CANCEL_PUSH per current draft, then the peer will never know that that push stream has failed.

A possible suggested edit could be:
A server SHOULD NOT send a CANCEL_PUSH after it has completed a send on the corresponding push stream of the pushId.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3387