IETF Logo Mail Archive

Re: [quicwg/base-drafts] Include a token on all Initial packets (#1794)

ianswett <notifications@github.com> Thu, 27 September 2018 02:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 53A9E130DC3 for <quic-issues@ietfa.amsl.com>; Wed, 26 Sep 2018 19:40:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pG7HOEzeVCWR for <quic-issues@ietfa.amsl.com>; Wed, 26 Sep 2018 19:39:58 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3D11112F1AB for <quic-issues@ietf.org>; Wed, 26 Sep 2018 19:39:58 -0700 (PDT)
Date: Wed, 26 Sep 2018 19:39:57 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1538015997; bh=Jlq2P/BkdbsF6E9ejmmTurmAg/dw26jb6UNOKBU89vA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=CCIXfxwK46aRqYmC8Vn529Ze21aHJUbx5dwwXkABd/nF1WZ281VPmL7sBjJ0kSvci GgAc2OWBL3IN+docZxBneku+BzYdwatmuILukDAMBO2M82ZWr0su0qMWXck6F5ezYb 6DsJFv+HKUBsAMHAaqU6n+MtGCNfqT6sz0MWxIgI=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab640dc0ccc9b132413f399943c58f2a49a34a725092cf0000000117c404fd92a169ce15a88727@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1794/review/159266041@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1794@github.com>
References: <quicwg/base-drafts/pull/1794@github.com>
Subject: Re: [quicwg/base-drafts] Include a token on all Initial packets (#1794)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bac42fd6645f_18b93f958f0d45bc17944e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/LM5adbyJ94PpuDi6fhUAwchCpjE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Sep 2018 02:40:00 -0000

ianswett commented on this pull request.



> @@ -621,10 +621,18 @@ packet. It also sets the Token field to the token provided in the Retry. The
 client MUST NOT change the Source Connection ID because the server could include
 the connection ID as part of its token validation logic (see {{tokens}}).
 
+The Initial packet sent by the client in response to a Retry packet is subject
+to the same restrictions as the first Initial packet, with the exception of the
+value of the Destination Connection ID and Token fields, which are set as
+described here.  A client can either reuse the cryptographic handshake message

How about putting the last sentence in this paragraph first, then saying "Aside from this, the Initial packet sent by the client is subject to the same restrictions as the first Initial packet."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1794#pullrequestreview-159266041

v2.23.0 | Report a Bug | By Email