IETF Logo Mail Archive

Re: [quicwg/base-drafts] Only include a token in the "first" Initial (#1794)

ianswett <notifications@github.com> Tue, 25 September 2018 20:11 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E3493130DC5 for <quic-issues@ietfa.amsl.com>; Tue, 25 Sep 2018 13:11:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.455
X-Spam-Level:
X-Spam-Status: No, score=-3.455 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z6VwN7uQnZCr for <quic-issues@ietfa.amsl.com>; Tue, 25 Sep 2018 13:11:09 -0700 (PDT)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C4D4C130DC4 for <quic-issues@ietf.org>; Tue, 25 Sep 2018 13:11:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=Smxxzh4LDvHM5I/1YecvUfaz4dQ=; b=WV5w1EqqwgeUxj6M hfMC0uS655bpUSgqu+p6jdLV39Sm5POM7W6bxh2PZ52zhkMvR4dGAWcNscnyDWzw Sym3abguDIOudnrLRLKY4dAERH3KwyCAX4uWDbZdagOQxswIFqrK2NuKbNshmY0Y GgFtd8EoAsKJjV3D6fO9DD9CXMo=
Received: by filter1843p1mdw1.sendgrid.net with SMTP id filter1843p1mdw1-18004-5BAA965B-1B 2018-09-25 20:11:07.416752376 +0000 UTC m=+7217.378160921
Received: from github-lowworker-e711880.cp1-iad.github.net (unknown [192.30.252.45]) by ismtpd0011p1iad2.sendgrid.net (SG) with ESMTP id ruXYMxzURp64QpOWhDyPOw for <quic-issues@ietf.org>; Tue, 25 Sep 2018 20:11:07.354 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e711880.cp1-iad.github.net (Postfix) with ESMTP id 46BCA4403C4 for <quic-issues@ietf.org>; Tue, 25 Sep 2018 13:11:07 -0700 (PDT)
Date: Tue, 25 Sep 2018 20:11:07 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4cded3e5f1ee287c04492c64526cd4abf390222992cf0000000117c2585b92a169ce15a88727@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1794/review/158723563@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1794@github.com>
References: <quicwg/base-drafts/pull/1794@github.com>
Subject: Re: [quicwg/base-drafts] Only include a token in the "first" Initial (#1794)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5baa965b44edc_699e3fb55f4d45b4139252"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2mJOwsWTU/QCpfWtRzP7NVNqN05lSJkYyw7X HgB85hXeHNm0aVXsLig6hxKC1lIOmkVMoKCQ2g0PcIQBJMQnA3kJgtgOjBUH4iURPQRsjl+dx39ZDH mimQjG1bzRbrXfvrlVRQtM5lP4c6SaRKAmDhA311cs0d4OakWYucelUIII0hXkae/a1FHErS6oqxy+ I=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/KXYeCiJinw5Od8Hc2i5ZCK5cRqw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Sep 2018 20:11:11 -0000

ianswett commented on this pull request.



> @@ -621,10 +621,19 @@ packet. It also sets the Token field to the token provided in the Retry. The
 client MUST NOT change the Source Connection ID because the server could include
 the connection ID as part of its token validation logic (see {{tokens}}).
 
+The Initial packet sent by the client in response to a Retry packet is subject
+to the same restrictions as the first Initial packet, with the exception of the
+value of the Destination Connection ID and Token fields, which are set as
+described here.  A client can either reuse the cryptographic handshake message
+or construct a new one at its discretion.  Any subsequent Initial packets from
+the client MUST use the same connection ID values, and MUST NOT include the

I thought the Retry now must change the CID?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1794#pullrequestreview-158723563

v2.23.0 | Report a Bug | By Email