Re: [quicwg/base-drafts] Reset the handshake timer on Retry and VN (#2024)

Subodh Iyengar <notifications@github.com> Tue, 20 November 2018 19:41 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F310F130DD0 for <quic-issues@ietfa.amsl.com>; Tue, 20 Nov 2018 11:41:25 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oaS8ESl46HJI for <quic-issues@ietfa.amsl.com>; Tue, 20 Nov 2018 11:41:24 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 88319130DCF for <quic-issues@ietf.org>; Tue, 20 Nov 2018 11:41:24 -0800 (PST)
Date: Tue, 20 Nov 2018 11:41:23 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542742883; bh=cHhesNu3GClGlhKNu7VbUTpQiOxrnN+8t6pjWyzvq/4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=QEEAerSs5axOx/w40IK8kjh1oVJn2JAlIaXiLIfutZDFGbRgUTICuvGI36GZWVJkV IFIA1eDM51BrfHToXdCOGD5DF8TO6Pe9riqbm/cNbNwOrjk8+OziP/w11AJ7xKicL7 kJW/AgONdXgrFO4WKhz8+jyyA0KGLE8P3PrsL4kU=
From: Subodh Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe08a2396dbecf80f83f8f89b0b566a8437c98d0192cf00000001180c256392a169ce16d10cb0@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2024/review/176942736@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2024@github.com>
References: <quicwg/base-drafts/pull/2024@github.com>
Subject: Re: [quicwg/base-drafts] Reset the handshake timer on Retry and VN (#2024)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bf46363a7bc7_2c823f806b0d45b4103855"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: siyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/MDWDmAOI-t33oPFVFsAb57Ugu3Q>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Nov 2018 19:41:26 -0000

siyengar commented on this pull request.



> @@ -375,7 +375,8 @@ packet, effectively restarting the connection process.
 
 Either packet indicates that the Initial was received but not processed.
 Neither packet can be treated as an acknowledgment for the Initial, but they MAY
-be used to improve the RTT estimate.
+be used to improve the RTT estimate.  Whether or not the RTT estimate is

Oh my suggestion was "Initial packets that are sent in response to the VN or Retry packets will reset the handshake timer."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2024#discussion_r235143549