Re: [quicwg/base-drafts] Reset the handshake timer on Retry and VN (#2024)

Subodh Iyengar <notifications@github.com> Tue, 20 November 2018 18:46 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A2572130DD8 for <quic-issues@ietfa.amsl.com>; Tue, 20 Nov 2018 10:46:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.47
X-Spam-Level:
X-Spam-Status: No, score=-3.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IPFGijEVw4bd for <quic-issues@ietfa.amsl.com>; Tue, 20 Nov 2018 10:46:00 -0800 (PST)
Received: from o10.sgmail.github.com (o10.sgmail.github.com [167.89.101.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D03C9130DCF for <quic-issues@ietf.org>; Tue, 20 Nov 2018 10:45:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=wSDgYAjMu0v8GfiBDV/tmYdWIQY=; b=InbR7EVsjeLwtMMd 6lkS7Q28xeGmaehJ0EBDxYmFaNRbF++qSCBGaO6yc/0d0r+oVYOgptg/gvHN6FoP ohWJY7KVG5x0+RBEtYO3BKonr046/zbKABaP/A4uPsTBxrkpwUjilqdAwP3iwGB9 vKs/6YUvszVGDuEXcZu6ui85FQI=
Received: by filter0233p1iad2.sendgrid.net with SMTP id filter0233p1iad2-29176-5BF45666-3C 2018-11-20 18:45:58.871810975 +0000 UTC m=+412134.473137434
Received: from github-lowworker-e51511d.cp1-iad.github.net (unknown [192.30.252.34]) by ismtpd0007p1iad2.sendgrid.net (SG) with ESMTP id aNUGa014TI-xzUB6NjpsKQ for <quic-issues@ietf.org>; Tue, 20 Nov 2018 18:45:58.837 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e51511d.cp1-iad.github.net (Postfix) with ESMTP id DA223811CD for <quic-issues@ietf.org>; Tue, 20 Nov 2018 10:45:58 -0800 (PST)
Date: Tue, 20 Nov 2018 18:45:58 +0000
From: Subodh Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abcfbc86e2846aa8075290dc00d5ca5e4991b75dc992cf00000001180c186692a169ce16d10cb0@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2024/review/176919320@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2024@github.com>
References: <quicwg/base-drafts/pull/2024@github.com>
Subject: Re: [quicwg/base-drafts] Reset the handshake timer on Retry and VN (#2024)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bf45666d7d50_1e93f9cdecd45b4107542"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: siyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak09OFImAw9HuMcGKoJCSd5JOaBenZc3KXzk6O 0ycL8jJW+NO5pi4O+tNVETUnJ9RVPrAZTNW4guUfMrPKzRDSNtR1JoOfm3X6wi05mPW+V8100kvSAK bRi5k+CG6z9pBoDFmvDQfgiHl7km/yykx7PQUh96cnEkXIUCeOGfqaLcfxhALcibo1ivkJ0/ZzmGLP o=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Zu4DTBIjdF5fWPMA9s9GWWgw3Y0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Nov 2018 18:46:02 -0000

siyengar commented on this pull request.



> @@ -375,7 +375,8 @@ packet, effectively restarting the connection process.
 
 Either packet indicates that the Initial was received but not processed.
 Neither packet can be treated as an acknowledgment for the Initial, but they MAY
-be used to improve the RTT estimate.
+be used to improve the RTT estimate.  Whether or not the RTT estimate is

hmm, wouldn't this automatically happen with the current. Receiving a VN or Retry will send a Handshake packet. Is this just editorial clarification?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2024#pullrequestreview-176919320