Re: [quicwg/base-drafts] Specify the packets that carry closing frames (#1890)

ianswett <notifications@github.com> Tue, 23 October 2018 01:46 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8C19F130DDD for <quic-issues@ietfa.amsl.com>; Mon, 22 Oct 2018 18:46:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x23xm1OFzSXt for <quic-issues@ietfa.amsl.com>; Mon, 22 Oct 2018 18:46:29 -0700 (PDT)
Received: from out-13.smtp.github.com (out-13.smtp.github.com [192.30.254.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A99DC130DD9 for <quic-issues@ietf.org>; Mon, 22 Oct 2018 18:46:29 -0700 (PDT)
Date: Mon, 22 Oct 2018 18:46:29 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540259189; bh=UI7ZikfEcZENUydHjLA7cNI/X77vFExTA3LiebmYd/0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=1C+YbQAWZBvM6Dh/Uz+JviQX9HC3mva0aD4RQ5jIQxd1f4+HgH/Sf0lpODdSNU0lS 5+T4vDvNyrv7abrUUA0fms2Z4pQAh7+hZHPB5WpJL4IiC6ewXCGFbpXjIfKN34ZJoE UQSJ4IpdrIpYv43HZ/m3FXLBU5kcRenUhcxY4Mx0=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abcd267c09ada5065a9148c93185be70cd54ea84f092cf0000000117e63f7592a169ce16295b25@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1890/review/167178417@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1890@github.com>
References: <quicwg/base-drafts/pull/1890@github.com>
Subject: Re: [quicwg/base-drafts] Specify the packets that carry closing frames (#1890)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bce7d7515385_477e3fab840d45c0547715f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Mae_foM3hrx9zn95e6J4mr1kB_k>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Oct 2018 01:46:32 -0000

ianswett commented on this pull request.



> @@ -2313,6 +2304,13 @@ the application requests that the connection be closed.  The application
 protocol can use an APPLICATION_CLOSE message with an appropriate error code to
 signal closure.
 
+If the connection has been successfully established, endpoints MUST send any
+closing frames in a 1-RTT packet.  Prior to connection establishment, endpoints
+SHOULD send closing frames in a Handshake packet.  An endpoint MAY send closing

Does this need a caveat like "...SHOULD send closing frames in a Handshake packet if possible."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1890#pullrequestreview-167178417