IETF Logo Mail Archive

Re: [quicwg/base-drafts] Restrict PUSH_PROMISE to request streams (#2323)

Mike Bishop <notifications@github.com> Thu, 10 January 2019 17:21 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3890C130F03 for <quic-issues@ietfa.amsl.com>; Thu, 10 Jan 2019 09:21:25 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.149
X-Spam-Level:
X-Spam-Status: No, score=-11.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0L2Qfm9eUS0H for <quic-issues@ietfa.amsl.com>; Thu, 10 Jan 2019 09:21:24 -0800 (PST)
Received: from out-14.smtp.github.com (out-14.smtp.github.com [192.30.254.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 01639130EFF for <quic-issues@ietf.org>; Thu, 10 Jan 2019 09:21:24 -0800 (PST)
Date: Thu, 10 Jan 2019 09:21:23 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1547140883; bh=2P832vWzmkha4+jjyFUGsqnVpt2OSXhFHHCFInCgeNc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=db3W34JvwcWk/T19uanYWXcarTDSws9kTx2zdHiwVAjI5OmYRhQAOFKHzKrmZ9J+X 3paq29nwTNESs0YpTXI0YV50a1Dq3GsBmsMFLaKkRJgd8E1MmxexQrdE6erWYAlIb5 zuIKwat83W2vcENmB8A9iEGUU6PB7kPwSJ6M+VbQ=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab32ea989b2c4518a5ae97a8c8bcd68a5fa049480b92cf00000001184f411392a169ce17b13d9c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2323/review/191322281@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2323@github.com>
References: <quicwg/base-drafts/pull/2323@github.com>
Subject: Re: [quicwg/base-drafts] Restrict PUSH_PROMISE to request streams (#2323)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c377f13487ac_17ae3fb6972d45b42047cf"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Mo4b_2vFnzqIZdIm5uQNZE64FVY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Jan 2019 17:21:25 -0000

MikeBishop commented on this pull request.



> @@ -723,7 +723,7 @@ with its 0-RTT data.
 ### PUSH_PROMISE {#frame-push-promise}
 
 The PUSH_PROMISE frame (type=0x05) is used to carry a promised request header
-set from server to client, as in HTTP/2.
+set from server to client on a request stream, as in HTTP/2.

Right -- same as 7540.  The reason for this is that once a request stream is closed, you know the full set of pushes that are expected in relation to that request.  However, if you allow new promises on push streams, you have to wait until all pushes are satisfied to get a complete set.

I'd be open to a discussion on loosening that requirement, but it's unrelated to QUIC -- write an HTTPbis draft advocating the change if you want it.  :-)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2323#discussion_r246849126

v2.23.0 | Report a Bug | By Email