IETF Logo Mail Archive

Re: [quicwg/base-drafts] Execute the PTO alarm immediately if in the past (#4831)

ianswett <notifications@github.com> Thu, 04 March 2021 15:03 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F13713A0CE7 for <quic-issues@ietfa.amsl.com>; Thu, 4 Mar 2021 07:03:26 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.802
X-Spam-Level:
X-Spam-Status: No, score=-1.802 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.248, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gL-VFdV9rIq9 for <quic-issues@ietfa.amsl.com>; Thu, 4 Mar 2021 07:03:21 -0800 (PST)
Received: from smtp.github.com (out-25.smtp.github.com [192.30.252.208]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D65BC3A0CE8 for <quic-issues@ietf.org>; Thu, 4 Mar 2021 07:03:21 -0800 (PST)
Received: from github.com (hubbernetes-node-c27faef.ash1-iad.github.net [10.56.113.29]) by smtp.github.com (Postfix) with ESMTPA id 1FA13840E68 for <quic-issues@ietf.org>; Thu, 4 Mar 2021 07:03:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1614870201; bh=Tnj9ohPD6V0ZSx64RUUDi3xgA8J83LBc6jYZAM0Zjns=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=kbs+tPGB0HgBG/3CpzNOR7ZBJeHXGCjKftN1NzEfPu9ef7ad8ffXnWeOhAPaz0JRH i+hr3tW0UO9ir9AdmzbEKVsbeZPhI/pY3CAvZZvM6ocpWoZu9JVcBk5jY9IQcJntjO dFAaK+bc3auRfNaH+2QaMaFPIGckuZ5BpSNzhPDw=
Date: Thu, 04 Mar 2021 07:03:21 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6IIYSAVJI6NERC3656JTL3TEVBNHHDBDTNMQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4831/review/604198584@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4831@github.com>
References: <quicwg/base-drafts/pull/4831@github.com>
Subject: Re: [quicwg/base-drafts] Execute the PTO alarm immediately if in the past (#4831)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_6040f6b91ce59_25d17d42070aa"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Mo8neFYt2QnyaWls9Lsxj4kHhj4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Mar 2021 15:03:27 -0000

@ianswett commented on this pull request.



> @@ -1375,6 +1381,10 @@ OnDatagramReceived(datagram):
   // PTO timer to avoid deadlock.
   if (server was at anti-amplification limit):
     SetLossDetectionTimer()
+    if loss_detection_timer.timeout < now():
+      // Execute PTO if it would have expired
+	    // while the amplification limit applied.

```suggestion
	     // while the amplification limit applied.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4831#pullrequestreview-604198584

v2.23.0 | Report a Bug | By Email