Re: [quicwg/base-drafts] Add an enum indicating the timer_mode (#3182)
ianswett <notifications@github.com> Sat, 02 November 2019 11:48 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 89C0E1200E6 for <quic-issues@ietfa.amsl.com>; Sat, 2 Nov 2019 04:48:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wcKKVLJfWrLs for <quic-issues@ietfa.amsl.com>; Sat, 2 Nov 2019 04:48:15 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D87771200C3 for <quic-issues@ietf.org>; Sat, 2 Nov 2019 04:48:12 -0700 (PDT)
Received: from github-lowworker-c53a806.ac4-iad.github.net (github-lowworker-c53a806.ac4-iad.github.net [10.52.23.45]) by smtp.github.com (Postfix) with ESMTP id 3E4DFC60697 for <quic-issues@ietf.org>; Sat, 2 Nov 2019 04:48:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572695292; bh=56Ak5eKp9mod+zPfIPvLoIOqZW7W0f3t/wWiZRB7gso=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Ic9kfEQfcWu/M9l6OrgB0Idr/lTJY73dAIzwTKUz2cKn23fwnciX60buLATWZzz46 NcrxSP/4Fp++fLNm1Qg+jucbk9+MalhUqNzzJeGo6SAu9cylF41QbL1667/lSqWx4v ZqDucQIlv6BFpcN2T7q950gU91Wc9nnHs2ZNFZCA=
Date: Sat, 02 Nov 2019 04:48:12 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2I7CNS56FHC7C7Q653ZKWYZEVBNHHB5RLS4Q@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3182/review/310767447@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3182@github.com>
References: <quicwg/base-drafts/pull/3182@github.com>
Subject: Re: [quicwg/base-drafts] Add an enum indicating the timer_mode (#3182)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dbd6cfc2f0c2_40b23f8b0eecd9604736e7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/NfuQjwSZUfHOFbc5rmMaPFpxbc4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Nov 2019 11:48:17 -0000
ianswett commented on this pull request. > @@ -1151,12 +1157,13 @@ Pseudocode for OnLossDetectionTimeout follows: ~~~ OnLossDetectionTimeout(): - loss_time, pn_space = GetEarliestLossTime() - if (loss_time != 0): - // Time threshold loss Detection - DetectLostPackets(pn_space) - SetLossDetectionTimer() - return + if (timer_mode == LOSS_DETECTION): + loss_time, pn_space = GetEarliestLossTime() + if (loss_time != 0): I think we either need an if check or an ASSERT. The following code does not work correctly if you did enter it code and loss_time was 0. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3182#discussion_r341808463
- [quicwg/base-drafts] Add an enum indicating the t… ianswett
- Re: [quicwg/base-drafts] Add an enum indicating t… Jana Iyengar
- Re: [quicwg/base-drafts] Add an enum indicating t… Marten Seemann
- Re: [quicwg/base-drafts] Add an enum indicating t… ianswett
- Re: [quicwg/base-drafts] Add an enum indicating t… ianswett
- Re: [quicwg/base-drafts] Add an enum indicating t… ianswett