Re: [quicwg/base-drafts] NEW_CONNECTION_ID: use sequence number for one CID only (#2096)

Dmitri Tikhonov <notifications@github.com> Tue, 04 December 2018 16:12 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 369EE128CF2 for <quic-issues@ietfa.amsl.com>; Tue, 4 Dec 2018 08:12:23 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KT0SwOUGrLNp for <quic-issues@ietfa.amsl.com>; Tue, 4 Dec 2018 08:12:21 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 28524130F24 for <quic-issues@ietf.org>; Tue, 4 Dec 2018 08:12:21 -0800 (PST)
Date: Tue, 04 Dec 2018 08:12:20 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543939940; bh=kAJoUsBsw3XcKR2TUajabtbq38zjYcTZEgm1vaXnGJY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ZBYJmcgdmVGPy3h0KlLr8CHr07dUyrKfAmUvk5/MXFZDsukv6R/5AdfzLj/W7rcwT H6lru8XhmvnLiLrapsZO/kaFBmEhYlpLqKeJUt8UsIwBEYcb6biipWYLXtatrnIh+l nXOsnyz3ODJYnmO3u4zKFuuycI6SbTyN6ZojMUpg=
From: Dmitri Tikhonov <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8942855eaf6c8c6eb280d46e8dbe972c2a102bae92cf00000001181e696492a169ce171693ce@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2096/c444157254@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2096@github.com>
References: <quicwg/base-drafts/pull/2096@github.com>
Subject: Re: [quicwg/base-drafts] NEW_CONNECTION_ID: use sequence number for one CID only (#2096)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c06a76459b57_43203faf05cd45bc2601c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: dtikhonov
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/PAUthjU5lfB-MGSNoolMPt8vlEg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Dec 2018 16:12:30 -0000

As long as we are checking for for consistency, it makes sense to check that sequence number has not been reused.  Sequence number reuse means that there is no longer a one-to-one correspondence between CIDs and sequence numbers.

The check is opportunistic (thus it's a **MAY** treat it as an error): if the peer has a record from previous _NEW_CONNECTION_ID_ `(seqno: A, cid: ABC)` but it receives `(seqno: A, cid: XYZ)`, it is an error.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2096#issuecomment-444157254