IETF Logo Mail Archive

[quicwg/base-drafts] Test vectors (#2274)

Martin Thomson <notifications@github.com> Mon, 31 December 2018 01:01 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8EFED1310BF for <quic-issues@ietfa.amsl.com>; Sun, 30 Dec 2018 17:01:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.065
X-Spam-Level:
X-Spam-Status: No, score=-8.065 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8P61-uT0Tnca for <quic-issues@ietfa.amsl.com>; Sun, 30 Dec 2018 17:01:47 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D3FB4130DDC for <quic-issues@ietf.org>; Sun, 30 Dec 2018 17:01:46 -0800 (PST)
Date: Sun, 30 Dec 2018 17:01:44 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546218104; bh=uCIFLVd01jTXpfGmK8EW7YVUhMHSZcRguC67dw1vrCM=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=DWT7PqWupycR1y918zWS9H5Hs2ceAXFTK6n1Ybo+zTBAtBe+gn0sM7vi8zr5jQ7jR 8bxSA08gLlUaxN1zQjjhm5K3Zok+pLo0oouBW0BTD8X7BM/MHG7YvlYLiyiLfDuRGz P38LAKZxVzixDZLkexxqHmllhFeKoFB6pWjDQ9jk=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb88fa027c83070a31d97137c7ea44979bb3d853092cf0000000118412c7892a169ce1789eea9@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2274@github.com>
Subject: [quicwg/base-drafts] Test vectors (#2274)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c296a78d14e0_3adb3f7f2b8d45c0292345"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/QxP_FRNiJd0Yk9FzgQdbdyEo5lw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Dec 2018 01:01:50 -0000

This takes @rpaulo's example and expands on it, hopefully without destroying it.

In summary:

* the output is condensed a little, which keeps the giant client Initial somewhat more in check
* added formula and variable names consistent with the rest of the spec for context
* added packet protection

The known bug here is that the ClientHello doesn't include transport parameters.  The ServerHello should be OK.  And I think that the ACK is correct also.  I did try to get the connection IDs and packet numbers correct.

I would appreciate someone checking my work.  I don't have a convenient method of testing this.

Closes #1573.
You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/2274

-- Commit Summary --

  * Add an appendix containing test vectors for "Initial".
  * Merge remote-tracking branch 'upstream/master' into test-vectors-initial
  * Fix a problem with the encoded labels.
  * Lint checks.
  * Merge remote-tracking branch 'upstream/master' into test-vectors-initial
  * Update sample vector to match draft 17.
  * Improve formatting, add more context, add packets

-- File Changes --

    M draft-ietf-quic-tls.md (198)

-- Patch Links --

https://github.com/quicwg/base-drafts/pull/2274.patch
https://github.com/quicwg/base-drafts/pull/2274.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2274

v2.23.0 | Report a Bug | By Email