IETF Logo Mail Archive

Re: [quicwg/base-drafts] Test vectors (#2274)

Marten Seemann <notifications@github.com> Sat, 05 January 2019 07:02 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 72A60130DE9 for <quic-issues@ietfa.amsl.com>; Fri, 4 Jan 2019 23:02:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.065
X-Spam-Level:
X-Spam-Status: No, score=-8.065 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CxthTQqguhO9 for <quic-issues@ietfa.amsl.com>; Fri, 4 Jan 2019 23:02:44 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 43432129B88 for <quic-issues@ietf.org>; Fri, 4 Jan 2019 23:02:44 -0800 (PST)
Date: Fri, 04 Jan 2019 23:02:42 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546671762; bh=Gmrf3J6Q+8atf3vZF+/lklOFjRxxESRDz9zq4ntfb70=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=cLkYqE/vCMm5SsBKeCVDgdtcyQwVndMK8E7T6MdQh7TpQkGkHo42OaEpmn5Cau1bP 00mqAiHsymgxaAR+WV6hdzKbB5f1WS6zivajThl730k051N7WT7zqgdZFascsfEgTG nX9vueC0PbDWBAm+dlzK9zTjozXywKajfFfo6e6U=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab5c0db80b2acb209705dcb2ecb37d915011b7623392cf000000011848189292a169ce1789eea9@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2274/review/189587995@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2274@github.com>
References: <quicwg/base-drafts/pull/2274@github.com>
Subject: Re: [quicwg/base-drafts] Test vectors (#2274)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c305692cf0be_179e3fd7932d45c4160674"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jHL-0sJHRiLSC_44jmGiXHq-2L0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Jan 2019 07:02:46 -0000

marten-seemann commented on this pull request.

I also added the vector to a unit test of quic-go, and I'm getting the same values.
As noted in my in-line comment, I'd prefer to use different packet numbers for both packets sent from client and server.

> +
+~~~
+060040c4010000c003036660261ff947 cea49cce6cfad687f457cf1b14531ba1
+4131a0e8f309a1d0b9c4000006130113 031302010000910000000b0009000006
+736572766572ff01000100000a001400 12001d00170018001901000101010201
+03010400230000003300260024001d00 204cfdfcd178b784bf328cae793b136f
+2aedce005ff183d7bb14952072366470 37002b0003020304000d0020001e0403
+05030603020308040805080604010501 060102010402050206020202002d0002
+0101001c00024001
+~~~
+
+The unprotected header includes the connection ID and a 4 byte packet number
+encoding:
+
+~~~
+c3ff000012508394c8f03e51570800449f00000000

Can we use a different packet number than 0 here? XORing the IV with 0 is special case when calculating the nonce for the AEAD, so I'd prefer to use *any* other value here.

> +
+The server sends the following payload in response, including an ACK frame, a
+CRYPTO frame, and no PADDING frames:
+
+~~~
+0d0000000018410a020000560303eefc e7f7b37ba1d1632e96677825ddf73988
+cfc79825df566dc5430b9a045a120013 0100002e00330024001d00209d3c940d
+89690b84d08a60993c144eca684d1081 287c834d5311bcf32bb9da1a002b0002
+0304
+~~~
+
+The header from the server includes a new connection ID and a 2-byte packet
+number encoding:
+
+~~~
+c1ff00001205f067a5502a4262b50040740000

Same here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2274#pullrequestreview-189587995

v2.23.0 | Report a Bug | By Email