Re: [quicwg/base-drafts] Modify QPACK steam and instruction terminology (#2440)

[Martin Thomson <[e-mail]>]

martinthomson commented on this pull request.



>  
-QPACK instructions occur in three locations, each of which uses a separate
-instruction space:
+There are three separate QPACK instruction spaces. Encoder instructions
+({{encoder-instructions}}) carry table updates, decoder instructions
+({{decoder-instructions}}) carry acknowledgments of table modifications and
+header processing, and header block instructions ({{header-block-instructions}})
+reference the QPACK table state.

Isn't the main purpose of header block instructions to cause header fields to be emitted?

>  
-## Encoder Stream {#encoder-stream}
+<!-- s/exactly/no more than/  ? -->
+HTTP/3 endpoints contain a QPACK encoder and decoder. Each endpoint MUST
+initiate a single encoder stream and decoder stream. Receipt of a second
+instance of either stream type MUST treat it as a connection error of type

Check grammar: "An endpoint that receives a second" or "MUST be treated as"

> @@ -811,11 +819,13 @@ An encoder cannot infer from this instruction that any updates to the dynamic
 table have been received.
 
 
-## Request and Push Streams
+## Header Block Instructions
+
+HTTP/3 endpoints convert header lists to headers blocks and exchange them inside
+HEADERS and PUSH_PROMISE frames. Header block instructions reference the static
+table, or dynamic table in a particular state without modifying it.

Same comment as before.  The primary purpose is to convey the header field values.  That they reference various tables to do so is secondary.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2440#pullrequestreview-201928026