IETF Logo Mail Archive

Re: [quicwg/base-drafts] Describe what happens if TLS breaks (#3587)

Eric Kinnear <notifications@github.com> Mon, 20 April 2020 06:24 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 666933A118A for <quic-issues@ietfa.amsl.com>; Sun, 19 Apr 2020 23:24:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.5
X-Spam-Level:
X-Spam-Status: No, score=-0.5 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=0.7, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dkn_CI5Sap8h for <quic-issues@ietfa.amsl.com>; Sun, 19 Apr 2020 23:24:03 -0700 (PDT)
Received: from out-26.smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2B3E03A1189 for <quic-issues@ietf.org>; Sun, 19 Apr 2020 23:24:03 -0700 (PDT)
Received: from github-lowworker-c5134a3.ac4-iad.github.net (github-lowworker-c5134a3.ac4-iad.github.net [10.52.23.55]) by smtp.github.com (Postfix) with ESMTP id 8077A282C58 for <quic-issues@ietf.org>; Sun, 19 Apr 2020 23:24:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1587363842; bh=6k+ayhyVGQw+X/BpzO4tkgpUAsUjvagrIMjoZLC06F4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=T+bTCM9uNitunQbFsTqQDLY7xiT70Ji+K2BLjrRuR/rfm8XCzaDFVNXPaGjDlZ9PZ s+YjmrdLer0LBZsTCN5gsSPM+VRAt72o8IPRTXBlqEzLHlK6zJZem/Eq83wCxnMoK6 oi8U350MuLhi2lIcrAg30oQ8RloXwY5uEqlmCsTY=
Date: Sun, 19 Apr 2020 23:24:02 -0700
From: Eric Kinnear <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2YHODDIJA6HP66GC54VEQQFEVBNHHCH4FIHU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3587/review/396167797@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3587@github.com>
References: <quicwg/base-drafts/pull/3587@github.com>
Subject: Re: [quicwg/base-drafts] Describe what happens if TLS breaks (#3587)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e9d40027044c_23983f83cd6cd9609240bd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: erickinnear
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/VtTBdPoXTpFiKxc1jwQgr0tMSKU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Apr 2020 06:24:04 -0000

@erickinnear approved this pull request.

Looking good, thanks for writing this!

> +of confidentiality protections, both from the negotiation of keys using the TLS
+handshake and from QUIC packet protection, to avoid linkability across network

Minor word nit:
```suggestion
of confidentiality protections, both for the negotiation of keys using the TLS
handshake and for QUIC packet protection, to avoid linkability across network
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3587#pullrequestreview-396167797

v2.23.0 | Report a Bug | By Email