Re: [quicwg/base-drafts] Request Forgery Attacks through Version Negotiation (#4258)

Marten Seemann <notifications@github.com> Fri, 06 November 2020 04:51 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0FED43A0C96 for <quic-issues@ietfa.amsl.com>; Thu, 5 Nov 2020 20:51:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nm70aQUVcr_j for <quic-issues@ietfa.amsl.com>; Thu, 5 Nov 2020 20:51:41 -0800 (PST)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 532473A0C8E for <quic-issues@ietf.org>; Thu, 5 Nov 2020 20:51:41 -0800 (PST)
Received: from github.com (hubbernetes-node-0ac3a5d.va3-iad.github.net [10.48.17.12]) by smtp.github.com (Postfix) with ESMTPA id 906E3E0D62 for <quic-issues@ietf.org>; Thu, 5 Nov 2020 20:51:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1604638300; bh=4ULVSJCH+LCTbPgw/mguhe1ZI9cQ/9OVXq2MjKXMuk4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=V7/a9IYj+OGsdVpR0G4oMs3xEj0AamLnMs4FDjFt/TKYQYlHb8daROqu+b/ld/R6Z tavhh26rHCfXOPxc2UBHi2ZcGjkiawIhC6PJyg29nkTUMKdc+9v5RQdtyMWuWu1mcc KJSBN7Ax5KZrUbq6GjUGGM7+gtrw4Vmci6JSVP4w=
Date: Thu, 05 Nov 2020 20:51:40 -0800
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZYDFANC6AIPDUC7VF5WC3VZEVBNHHCWU2F3Y@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/4258/722814278@github.com>
In-Reply-To: <quicwg/base-drafts/issues/4258@github.com>
References: <quicwg/base-drafts/issues/4258@github.com>
Subject: Re: [quicwg/base-drafts] Request Forgery Attacks through Version Negotiation (#4258)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5fa4d65c8d2f3_3f19b429090"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/X3Cj4_a2miTsh95v-Pm0yDkafpk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Nov 2020 04:51:43 -0000

> My response is that in general you need some sort of signaling between peers to communicate addresses for p2p. NAT traversal generally requires it, and - if nothing else - you usually need to ship IP addresses for peers around.

This independent of NAT traversal then. You'd also need to advertise addresses in a world where NATs wouldn't exist, and you could include QUIC version information in those address advertisements.

This still leaves the Bootstrap nodes susceptible to this attack (assuming you only hard-code a list of IP:ports without QUIC version information), but maybe that's ok, since you typically control those nodes yourself, or at least you can ask people running those nodes to take precautionary steps.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/4258#issuecomment-722814278