IETF Logo Mail Archive

Re: [quicwg/base-drafts] Remove packets from flight when RTO is verified (#1582)

Subodh Iyengar <notifications@github.com> Thu, 19 July 2018 02:41 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AC640130E7D for <quic-issues@ietfa.amsl.com>; Wed, 18 Jul 2018 19:41:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QfG1EO19awyb for <quic-issues@ietfa.amsl.com>; Wed, 18 Jul 2018 19:41:35 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4C9F1130E78 for <quic-issues@ietf.org>; Wed, 18 Jul 2018 19:41:35 -0700 (PDT)
Date: Wed, 18 Jul 2018 19:41:34 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1531968094; bh=QticKssDSUooBlG63mbPB8rgB4nxzPizkp+Nfmxktno=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=spUUMnO6ET8gTAsxzum+T/+h8Tx8DGStuOioxrAngkHtnkIzA1ubGlT3b1dnSsxPc NuZX7D156NRI3PUjXZ1hgAi0qa8DtEkPq22XwjgRN669kmQoZNxKTnGSy51lz95+wb DrctWmAZv8rWtnXLzuJ+2yqqFFik4p6/n+VJFjOg=
From: Subodh Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab61fec851c49cfd01378cff715d3ea7411c22989a92cf000000011767bc5e92a169ce14699ead@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1582/review/138506109@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1582@github.com>
References: <quicwg/base-drafts/pull/1582@github.com>
Subject: Re: [quicwg/base-drafts] Remove packets from flight when RTO is verified (#1582)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b4ffa5e29d17_5433f87cdabef8417720"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: siyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/YOtjC5Pd3PLeq6i_U-gwoXbKa1k>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jul 2018 02:41:38 -0000

siyengar commented on this pull request.



>  
 ~~~
-   OnRetransmissionTimeoutVerified()
+   OnRetransmissionTimeoutVerified(packet_number)

i think OnPacketAcked() needs to be changed as well too pass in largest_sent packet right?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1582#pullrequestreview-138506109

v2.23.0 | Report a Bug | By Email