Re: [quicwg/base-drafts] all HTTP/3 protocol violations should lead to connection errors (#2510)

Mike Bishop <notifications@github.com> Tue, 16 April 2019 20:59 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A88EA1203FD for <quic-issues@ietfa.amsl.com>; Tue, 16 Apr 2019 13:59:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.001
X-Spam-Level:
X-Spam-Status: No, score=-3.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xk4N11mHpqie for <quic-issues@ietfa.amsl.com>; Tue, 16 Apr 2019 13:59:15 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3C8BB120169 for <quic-issues@ietf.org>; Tue, 16 Apr 2019 13:59:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=JchEyUFUfoO5I87SxNeD/r1xIpk=; b=niL45HY5mZGpxr1x XNmIPj3qAOGeyTvK43BbIsx+nftW3ArwSKYIqTMN3snxy9WjxF7MwGsy+KFfOPBj hNVzXgfWS5oTBsU3Ikhvie+0TTX0MhvMyW38oUD/qKVc9zH2S+3NSt8GG+8e+XW2 Tqp7H5tQg/Vrk2tnBsfPQHGK0d8=
Received: by filter0554p1iad2.sendgrid.net with SMTP id filter0554p1iad2-11161-5CB64221-2D 2019-04-16 20:59:13.945637771 +0000 UTC m=+681333.180746190
Received: from github-lowworker-e51511d.cp1-iad.github.net (unknown [192.30.252.34]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id RmVnCNNMQcecuQfLo-H2ug for <quic-issues@ietf.org>; Tue, 16 Apr 2019 20:59:13.810 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e51511d.cp1-iad.github.net (Postfix) with ESMTP id C347E80941 for <quic-issues@ietf.org>; Tue, 16 Apr 2019 13:59:13 -0700 (PDT)
Date: Tue, 16 Apr 2019 20:59:13 +0000 (UTC)
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abffd2cfa49ff597f2c87d5e7daf1d9de9ac15202b92cebac374a192a169ce18fa182f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2510/review/227427686@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2510@github.com>
References: <quicwg/base-drafts/pull/2510@github.com>
Subject: Re: [quicwg/base-drafts] all HTTP/3 protocol violations should lead to connection errors (#2510)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cb64221c1494_7f8b3f99a3cd45c03700d8"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1keZBHRYfHajtqT5kY9yFywpYdVH2NgTitED Th1gyj5EXEO7EYcIxPh5aSH4LwfyDPWeQ+i9lSw5dLnlQEReZ2uNEoyPW2P/2HaLWfxfwNLf9Zx0sJ 3erP+/wGWWhyAcrhC2r5Slx/YfZVKl4b9b3tZcdmSw7z1xed8PtjKIGLzL5Qe5gOCQbH6WcLnRII5Z E=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/_3oa1teKXD9xeSgQMJiVmTo9A3s>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Apr 2019 20:59:18 -0000

MikeBishop commented on this pull request.

@kazuho, thanks for writing this up.  I'm still a little torn about making almost every possible error a connection error, but they are correctness issues.  Are you planning to address the two points you raise above?

> @@ -586,10 +586,10 @@ using a Stream ID of 0, as in QUIC stream 0 carries a valid HTTP request.  The
 root of the tree cannot be reprioritized.  A PRIORITY frame sent on a request
 stream with the Prioritized Element Type set to any value other than `11` or
 which expresses a dependency on a request with a greater Stream ID than the
-current stream MUST be treated as a stream error of type HTTP_MALFORMED_FRAME.
-Likewise, a PRIORITY frame sent on a control stream with the Prioritized Element
-Type set to `11` MUST be treated as a connection error of type
-HTTP_MALFORMED_FRAME.
+current stream MUST be treated as a connection error of type
+HTTP_MALFORMED_FRAME.  Likewise, a PRIORITY frame sent on a control stream with
+the Prioritized Element Type set to `11` MUST be treated as a connection error
+of type HTTP_MALFORMED_FRAME.

Since this paragraph is structured as "things that cause a stream error" and "things that cause a connection error," I suspect we could fold everything together if everything is going to be a connection error.  Maybe even something like:

```
The following situations MUST be treated as connection errors of type HTTP_MALFORMED_FRAME:
  - A PRIORITY frame sent on a request stream with the Prioritized Element
    Type set to any value other than `11`
  - A PRIORITY frame which expresses a dependency on a request with a 
    greater Stream ID than the	current stream  
  - A PRIORITY frame sent on a control stream with the Prioritized Element
    Type set to `11`
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2510#pullrequestreview-227427686