Re: [quicwg/base-drafts] Allow ClientHello to span multiple QUIC packets (#3045)

Martin Thomson <notifications@github.com> Tue, 24 September 2019 23:39 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 39EBA1201AA for <quic-issues@ietfa.amsl.com>; Tue, 24 Sep 2019 16:39:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M5kN9AGUa1Tx for <quic-issues@ietfa.amsl.com>; Tue, 24 Sep 2019 16:39:18 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 41F85120033 for <quic-issues@ietf.org>; Tue, 24 Sep 2019 16:39:18 -0700 (PDT)
Date: Tue, 24 Sep 2019 16:39:17 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1569368357; bh=v7XqzvTcjKtNuCqIpEalvgvKOJT/phOi/bwsakhsW1Y=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=uXLtMEyTktlevqhFLRE6RB6itJR4hJR2+mHghskOza+75PPSGhAR1vDWb7ao/nobM d+Eg+SbIYuyqZyftcZpGOkldJSQcp/GuA+Vs+Z/+QaPxjfoBRLxnhU34tiMmOzsEbi O3wwAYKqHn4LxEuYAbhdNoCKNvdA1+DBZqMZ/pyo=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7MXDMDR7QMVQRCW5V3S7GZLEVBNHHB26JPGY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3045/review/292763064@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3045@github.com>
References: <quicwg/base-drafts/pull/3045@github.com>
Subject: Re: [quicwg/base-drafts] Allow ClientHello to span multiple QUIC packets (#3045)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d8aa9252cbb9_143e3f98dd0cd9643938f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/_mmmnq6zCGUH0XwkdZLvVzluJzE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Sep 2019 23:39:20 -0000

martinthomson approved this pull request.

Some residual singular/plural disagreements.

>  
-Note that if the server sends a HelloRetryRequest, the client will send a second
+Note that if the server sends a HelloRetryRequest, the client will send another
 Initial packet.  This Initial packet will continue the cryptographic handshake

```suggestion
series of Initial packets.  These Initial packets will continue the cryptographic handshake
```

>  
-Note that if the server sends a HelloRetryRequest, the client will send a second
+Note that if the server sends a HelloRetryRequest, the client will send another
 Initial packet.  This Initial packet will continue the cryptographic handshake
 and will contain a CRYPTO frame with an offset matching the size of the CRYPTO

```suggestion
and will contain CRYPTO frames starting at an offset matching the size of the CRYPTO
```

>  Initial packet.  This Initial packet will continue the cryptographic handshake
 and will contain a CRYPTO frame with an offset matching the size of the CRYPTO
-frame sent in the first Initial packet.  Cryptographic handshake messages
-subsequent to the first do not need to fit within a single UDP datagram.
+frame sent in the first Initial packet.

```suggestion
frames sent in the first flight of Initial packets.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3045#pullrequestreview-292763064