Re: [quicwg/base-drafts] Transport parameters are mandatory. Fixes #2528 (#2560)

Nick Harper <notifications@github.com> Tue, 16 April 2019 21:49 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DF85B1203C8 for <quic-issues@ietfa.amsl.com>; Tue, 16 Apr 2019 14:49:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id elveLMFBToiQ for <quic-issues@ietfa.amsl.com>; Tue, 16 Apr 2019 14:49:10 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EAF1812023D for <quic-issues@ietf.org>; Tue, 16 Apr 2019 14:49:09 -0700 (PDT)
Date: Tue, 16 Apr 2019 14:49:08 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1555451348; bh=RtVA50QmqEjfnUwMQHimFT/U75Yu+eWs6nK22tRM0g4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=uLK81T3sXLaXAICDIWwHyoNqxK8qacNQCngBQLwkonq42/eKgCWUXmgpvl6fB5yPp QucKywViKREtmCrbh96qlhbD2x6hk7aR4xynFVC3xe2yTzmEq6Oci/xZiDExrn4Wgc mykCkC1IcjslzYLifhkHBuXVjxlInpyCuG8ZRNk4=
From: Nick Harper <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3e7e993e8acd2215da79b2fd30a3392d0de4b76c92cebac3805492a169ce1961a1eb@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2560/review/227462762@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2560@github.com>
References: <quicwg/base-drafts/pull/2560@github.com>
Subject: Re: [quicwg/base-drafts] Transport parameters are mandatory. Fixes #2528 (#2560)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cb64dd4bc900_71943fa5340d45bc3048e6"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nharper
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/aOs08MF2-v2QfdpELBzfT3cqa5A>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Apr 2019 21:49:12 -0000

nharper commented on this pull request.



> @@ -1258,8 +1262,8 @@ parameters will cause the handshake to fail.
 
 Endpoints MUST NOT send this extension in a TLS connection that does not use
 QUIC (such as the use of TLS with TCP defined in {{!TLS13}}).  A fatal
-unsupported_extension alert MUST be sent if this extension is received when the
-transport is not QUIC.
+unsupported_extension alert (an error of 0x16e) MUST be sent if this extension
+is received when the transport is not QUIC.

I agree with @MikeBishop. Specifying the QUIC error code to send if the extension is received when the transport isn't QUIC doesn't make much sense.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2560#discussion_r276006637