Re: [quicwg/base-drafts] Make transport parameters varint (#3169)

David Schinazi <notifications@github.com> Tue, 29 October 2019 23:39 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 32A6C12006D for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 16:39:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i_A0rNq_0EEK for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 16:39:52 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 855E812006B for <quic-issues@ietf.org>; Tue, 29 Oct 2019 16:39:52 -0700 (PDT)
Received: from github-lowworker-d93c4b6.va3-iad.github.net (github-lowworker-d93c4b6.va3-iad.github.net [10.48.17.47]) by smtp.github.com (Postfix) with ESMTP id DB4EA6E0040 for <quic-issues@ietf.org>; Tue, 29 Oct 2019 16:39:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572392391; bh=FcY9pgaMFQv62fmxah+T30FHYv9zd6iPPe8+65RskcI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ruDvAig5MVQtEqEaKFlBBnU5c1Rrb19pWxgld1KcZC1mmnMubIM2MDKg28eiJYG6r cxIbGXuT4DWcXpf6U6Ee9Q2KN7vkxBMyCs3h+div9Nt3CNatECqC03OZ0hlk4V+MTa 5tIWrzJx6TNvgYcXMWN+ZMQXzVdlUnBR3PcRp58Q=
Date: Tue, 29 Oct 2019 16:39:51 -0700
From: David Schinazi <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3TPBGIZ5NGB3VWAAF3YYHFPEVBNHHB5JZ3ZA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3169/review/308896508@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3169@github.com>
References: <quicwg/base-drafts/pull/3169@github.com>
Subject: Re: [quicwg/base-drafts] Make transport parameters varint (#3169)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db8cdc7ca9a3_41743fa6cf0cd96486255"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: DavidSchinazi
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/aWyn5Aj4tFw88wUlWg0azp45hC4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Oct 2019 23:39:54 -0000

DavidSchinazi commented on this pull request.



> @@ -4571,10 +4565,14 @@ preferred_address (0x000d):
 +                                                               +
 |                                                               |
 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+| CID Length (8)|

Connection ID lengths use a 1-byte encoding throughout the document (long headers, NEW_CONNECTION_ID). I'd rather keep this consistent.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3169#discussion_r340375849