Re: [quicwg/base-drafts] PUSH_ID as a frame (#2526)

[Lucas Pardue <[e-mail]>]

> Take a server with a buggy push implementation, rather than a malicious one. Something that doesn't send the PUSH_ID at all. On the client you'll start seeing a flow of data and you can't do anything better than parsing the first few bytes of that as a PUSH_ID, and basically see random IDs. With Framing, if a server forgets to send the PUSH_ID, it is clear at the receiver that it is a protocol error.

Right now in draft 19 we have:

1. Parse varint  - stream type
2. Parse varint - push ID
3. Parse varint - frame type (HEADERS). 

The assertion then is, if step 2 gets skipped by the sender, the receiver will parse the HEADERS frame type as a varint expecting it to be the push ID (value 0x1, with no restriction on min or max encoding). It will then parse the HEADERS frame length as a varint expecting it to be the HEADERS frame type (length is unlikely to be 1). Doesn't the client just blow up at that point?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2526#issuecomment-474056430