Re: [quicwg/base-drafts] It is unclear if some frames are forbidden in 0-RTT (#3430)

Mike Bishop <notifications@github.com> Fri, 21 February 2020 20:07 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CB90B12006B for <quic-issues@ietfa.amsl.com>; Fri, 21 Feb 2020 12:07:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.682
X-Spam-Level:
X-Spam-Status: No, score=-3.682 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9MIvu5fYbhab for <quic-issues@ietfa.amsl.com>; Fri, 21 Feb 2020 12:07:52 -0800 (PST)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 71A2E12003E for <quic-issues@ietf.org>; Fri, 21 Feb 2020 12:07:52 -0800 (PST)
Received: from github-lowworker-2300405.va3-iad.github.net (github-lowworker-2300405.va3-iad.github.net [10.48.17.39]) by smtp.github.com (Postfix) with ESMTP id 5ECC88C0FF9 for <quic-issues@ietf.org>; Fri, 21 Feb 2020 12:07:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1582315671; bh=tJrNlcpg1450L77sDXKQr84JKrAmqZLYJizO6PfOtAw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=MC868GL+6EkOtm6ei05UODhjxmFRKMeHC/exaEXy3jGJA6IrRWlO+UUQ3eBwi7Whh hIl1veQNcKR6yXi7LHTzNoY+22S7NNQaGP0I3HNvyTFkCcEdU/sOklW9Y1jP2/3ilw KAFGvIt7xelmojJNiHSfn7dR719GD+tRxqSFgX2k=
Date: Fri, 21 Feb 2020 12:07:51 -0800
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3I4D52X7ZSI4CUNOV4LVVRPEVBNHHCC3RXUI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3430/589815129@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3430@github.com>
References: <quicwg/base-drafts/issues/3430@github.com>
Subject: Re: [quicwg/base-drafts] It is unclear if some frames are forbidden in 0-RTT (#3430)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e50389750561_19a43faaa3acd9648501d"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/bEFVh6AurG0JkmLZXUZRm7tzdwA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Feb 2020 20:07:54 -0000

I think you need both pieces of logic anyway.  If a peer sends HANDSHAKE_DONE in a Handshake frame, that's an error regardless of role.  You need to check the packet type on receipt.  If a client sends HANDSHAKE_DONE, that's an error regardless of packet type.  You need to check the peer's role on receipt.

The assertion here is that we don't need to expand the packet type check to overlap with the role check.  Then we get into discussion about which of multiple overlapping errors you should use.  We've done that already.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3430#issuecomment-589815129