IETF Logo Mail Archive

Re: [quicwg/base-drafts] STOP_SENDING on Critical Stream (#2509)

Ryan Hamilton <notifications@github.com> Sat, 09 March 2019 00:48 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A1B84127971 for <quic-issues@ietfa.amsl.com>; Fri, 8 Mar 2019 16:48:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.001
X-Spam-Level:
X-Spam-Status: No, score=-8.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sfjsROY-wnev for <quic-issues@ietfa.amsl.com>; Fri, 8 Mar 2019 16:48:06 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BFB2612796B for <quic-issues@ietf.org>; Fri, 8 Mar 2019 16:48:06 -0800 (PST)
Date: Fri, 08 Mar 2019 16:48:05 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1552092485; bh=7TVDlXyY601Bc5ZhTQn6+eLK0Jb95moP1nWYnwNjjJE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=U+KyvbjjAhXeF2lTCHTiZUebUwHNZ4+C3Gj/FsZIsRPX6GqWzRfjnQrCFLbsoklU7 aB9fVtcXelSV0mXm2tff6BksRnXyVnTyvbWbsVVKOam1N5sU8yDOA50EsLOOPWEvE6 wPHr5dCfa3mnB7Z1hec60cQwwQi6hAFsfjsl4iX8=
From: Ryan Hamilton <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abab7658aad18d73dd7641340b063342dfb1b8100292cf00000001189acf4592a169ce18f99aab@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2509/471127297@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2509@github.com>
References: <quicwg/base-drafts/issues/2509@github.com>
Subject: Re: [quicwg/base-drafts] STOP_SENDING on Critical Stream (#2509)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c830d458f853_26333fb53ced45b47667c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: RyanAtGoogle
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/cKRJgOBM_4tU9UJtwqEN15-f4wg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Mar 2019 00:48:08 -0000

On Fri, Mar 8, 2019 at 4:43 PM Mike Bishop <notifications@github.com> wrote:

> Perhaps I'm missing it but the spec doesn't say how to handle a
> STOP_SENDING received on a control stream. Should this peer issue a
> RESET_STREAM in response (causing the other peer to blow up) or should it
> just close the connection itself?
>
> *Originally posted by @LPardue <https://github.com/LPardue> in #2498
> (comment)
> <https://github.com/quicwg/base-drafts/issues/2498#issuecomment-470316968>*
>
> There are three reasonable places to blow up:
>
>    - When you decide to stop reading a critical stream (i.e. when
>    STOP_SENDING is sent)
>    - When you discover the peer has stopped reading a critical stream
>    (i.e. when STOP_SENDING is received)
>    - When you discover the peer has closed a critical stream (when
>    RESET_STREAM or FIN is received)
>
> My inclination would be to advise against FIN/S_S/R_S on a critical stream
> and mandate connection termination on receipt of any of them.
>
Completely agree. This seems like the simplest and most obvious solution.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2509#issuecomment-471127297

v2.23.0 | Report a Bug | By Email