Re: [quicwg/base-drafts] CANCEL_PUSH, MAX_PUSH_ID and GOAWAY specify the length of the ID twice (#1620)

Mike Bishop <notifications@github.com> Tue, 07 August 2018 19:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 27D7E131096 for <quic-issues@ietfa.amsl.com>; Tue, 7 Aug 2018 12:40:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yLJaJa49jccI for <quic-issues@ietfa.amsl.com>; Tue, 7 Aug 2018 12:40:01 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 333CA131084 for <quic-issues@ietf.org>; Tue, 7 Aug 2018 12:40:01 -0700 (PDT)
Date: Tue, 07 Aug 2018 12:40:00 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1533670800; bh=82ZYCiqOkjGqbSyNWbqe/AaYAMIVUm6gU0YSjuqTg58=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=aizcC1e3H7YR/XgUZJPJh2L9lUwE2CEzApNGsrPZjesc2H4snDdOhpATzC0yJJEc+ gVL4klXbgj2aHQ1F0SdRmrqlEjeYQeS5++xwuMT1fvR23cigeIHd7tOIWGnK12L7i9 ukVNGaGxUj2G/uOzjyPCeBXZrUsKTuSN2J4mG1uI=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab91ac146eebab16592dbb6aa6a576ae977b042af192cf000000011781b79092a169ce14a3a07f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1620/411177005@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1620@github.com>
References: <quicwg/base-drafts/issues/1620@github.com>
Subject: Re: [quicwg/base-drafts] CANCEL_PUSH, MAX_PUSH_ID and GOAWAY specify the length of the ID twice (#1620)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b69f5907a20e_35543ffd9fabe618484fc"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/eIMiRJqR9o7RLIj9ROolwVSxIAc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Aug 2018 19:40:03 -0000

I think that's a fair question, and I'm coming around to the idea of length-prefixed non-varint values for SETTINGS.  It's a level of complexity that seemed like we might need it coming out of HTTP/2, and a few years later that need hasn't proven itself out.

For these frames, we're referencing Stream IDs / Push IDs.  Stream IDs are a transport layer concept and I'm reluctant to introduce an alternative encoding.  We already have at least one place (PRIORITY) where Push and Stream IDs are encoded in the same field, which argues for using the same encoding for both.  If not varint, what?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1620#issuecomment-411177005