[quicwg/base-drafts] Migration before handshake completed is very messy (#2309)
Christian Huitema <notifications@github.com> Mon, 07 January 2019 04:54 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C23DB128D09 for <quic-issues@ietfa.amsl.com>; Sun, 6 Jan 2019 20:54:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.065
X-Spam-Level:
X-Spam-Status: No, score=-8.065 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Sm4iHIp7ylOY for <quic-issues@ietfa.amsl.com>; Sun, 6 Jan 2019 20:54:26 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E64BE1274D0 for <quic-issues@ietf.org>; Sun, 6 Jan 2019 20:54:25 -0800 (PST)
Date: Sun, 06 Jan 2019 20:54:24 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546836864; bh=t0OiF7UPvGm56Z76aglIZOnKaNvGVTq9avgX5lb7YOU=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=SP45/h/Tym6AUhlbBEA/+Dwca/OdWp118INKvs3L8E7N0sj9lhag/84v3rCH0GPyB YQJMq7JcOl2LBvT1qlfz39VCdAanhv7RwA2DWACMm/2maR0LTgB09xjAlA6ARIZPH1 fE1C39Hy/Sfb7C4e8pLD8tR42hasPH9bizO8l38A=
From: Christian Huitema <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8d8e746358b1a5cf5331acafb22dd95737fd632892cf00000001184a9d8092a169ce179fc90b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2309@github.com>
Subject: [quicwg/base-drafts] Migration before handshake completed is very messy (#2309)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c32db80c6540_71303fc7596d45c438922b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: huitema
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/fEy9rpi20THR4lS2Jmmzgw-9kBQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jan 2019 04:54:28 -0000
In migration interop tests, the Picoquic client was starting to simulate NAT rebinding just after obtaining the 1-RTT read and write key. That turns out to be very messy, because at that point there is no proof that the server has received the client finished message, let alone acknowledged it. As far as tests are concerned, there is an easy fix: only start the migration tests after the client has received from the server an ACK of one of its 1-RTT packet. That's the moment when the client knows for sure that the handshake is successful. The migration before handshake complete is messy because the client will try to re-transmit handshake messages that have not been acknowledged, and has some kind of dilemma. Should these re-transmissions aims at the original DCID used during the handshake, or at one of the new CID selected during the migration? What if the continuity of the new path has not been yet verified? What if the continuity test was lost? Do we have an actual need to support migration before the handshake is fully completed? In practice, the handshake packets create a NAT mapping, and it is rather unlikely that this mapping will just disappear before the few RTT required to complete the handshake. In fact, it is possible, maybe likely, that packets received from an alternative address during the handshake comes from attackers, not from the actual client. I think the implementations would be simpler and more robust if the spec stated that clients should not initiate "voluntary" migration before the handshake is fully complete. This means 1-RTT ACK received, or ACK of last handshake packet from the client, whichever comes first. Similarly, servers should not try to migrate connections before receiving at least one 1-RTT packet from the client through the same addresses and ports as the Initial messages. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/2309
- [quicwg/base-drafts] Migration before handshake c… Christian Huitema
- Re: [quicwg/base-drafts] Migration before handsha… Marten Seemann
- Re: [quicwg/base-drafts] Migration before handsha… Christian Huitema
- Re: [quicwg/base-drafts] Migration before handsha… erickinnear
- Re: [quicwg/base-drafts] Migration before handsha… Marten Seemann
- Re: [quicwg/base-drafts] Migration before handsha… Christian Huitema
- Re: [quicwg/base-drafts] Migration before handsha… ianswett
- Re: [quicwg/base-drafts] Migration before handsha… David Schinazi
- Re: [quicwg/base-drafts] Migration before handsha… Christian Huitema
- Re: [quicwg/base-drafts] Migration before handsha… ianswett
- Re: [quicwg/base-drafts] Migration before handsha… David Schinazi
- Re: [quicwg/base-drafts] Migration before handsha… MikkelFJ
- Re: [quicwg/base-drafts] Migration before handsha… Martin Thomson
- Re: [quicwg/base-drafts] Migration before handsha… Christian Huitema
- Re: [quicwg/base-drafts] Migration before handsha… Martin Thomson
- Re: [quicwg/base-drafts] Migration before handsha… Christian Huitema
- Re: [quicwg/base-drafts] Migration before handsha… Martin Thomson
- Re: [quicwg/base-drafts] Migration before handsha… Lars Eggert
- Re: [quicwg/base-drafts] Migration before handsha… Martin Thomson
- Re: [quicwg/base-drafts] Migration before handsha… Christian Huitema
- Re: [quicwg/base-drafts] Migration before handsha… ianswett
- Re: [quicwg/base-drafts] Migration before handsha… Christian Huitema
- Re: [quicwg/base-drafts] Migration before handsha… ianswett
- Re: [quicwg/base-drafts] Migration before handsha… Christian Huitema
- Re: [quicwg/base-drafts] Migration before handsha… Martin Thomson