Re: [quicwg/base-drafts] Rewrite Packet Size section (#2036)

[ianswett <[e-mail]>]

ianswett approved this pull request.

Nice PR, some small suggestions.

> @@ -2998,17 +2998,15 @@ The QUIC packet size includes the QUIC header and integrity check, but not the
 UDP or IP header.
 
 Clients MUST ensure that the first Initial packet they send is sent in a UDP

nit: how about:
"Clients MUST ensure they send the first Initial packet in a UDP datagram that is at least 1200 bytes."

> @@ -3023,83 +3021,108 @@ The server MUST also limit the number of bytes it sends before validating the
 address of the client, see {{address-validation}}.
 
 
-## Path Maximum Transmission Unit
+## Path Maximum Transmission Unit (PMTU)
+
+The PMTU is the maximum size of the entire IP packet including the IP header,
+UDP header, and UDP payload.  The UDP payload includes the QUIC packet header,
+protected payload, and any authentication fields. This can depend upon the

```suggestion
protected payload, and any authentication fields. The PMTU can depend upon the
```

> @@ -3023,83 +3021,108 @@ The server MUST also limit the number of bytes it sends before validating the
 address of the client, see {{address-validation}}.
 
 
-## Path Maximum Transmission Unit
+## Path Maximum Transmission Unit (PMTU)
+
+The PMTU is the maximum size of the entire IP packet including the IP header,
+UDP header, and UDP payload.  The UDP payload includes the QUIC packet header,
+protected payload, and any authentication fields. This can depend upon the
+current path characteristics.  Therefore, the current largest UDP payload an
+implementation will send is referred to as QUIC maximum packet size.

```suggestion
implementation will send is referred to as the QUIC maximum packet size.
```

>  
 If a QUIC endpoint determines that the PMTU between any pair of local and remote
-IP addresses has fallen below 1280 bytes, it MUST immediately cease sending QUIC
-packets on the affected path.  This could result in termination of the
-connection if an alternative path cannot be found.
+IP addresses has fallen below the size needed to support the smallest allowed
+maximum packet size, it MUST immediately cease sending QUIC packets on the
+affected path.  This could result in termination of the connection if an

This recommendation results in a timeout in cases where it may be possible to immediately close the connection if no other paths are available. I think it'd be preferable to close the connection, or say it MAY close the connection?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2036#pullrequestreview-178877642