Re: [quicwg/base-drafts] Rewrite Packet Size section (#2036)

Martin Thomson <notifications@github.com> Thu, 22 November 2018 22:24 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1559F130DD2 for <quic-issues@ietfa.amsl.com>; Thu, 22 Nov 2018 14:24:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q_UW2Hn-MkGz for <quic-issues@ietfa.amsl.com>; Thu, 22 Nov 2018 14:24:08 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6DE5A12D4EF for <quic-issues@ietf.org>; Thu, 22 Nov 2018 14:24:08 -0800 (PST)
Date: Thu, 22 Nov 2018 14:24:06 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542925446; bh=/bqZUdVjxmFwaFIgrf24CWNFwTU5QWpUn27g+19qqWw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=e9BPslsYCD6jV/it5OAGsHZQFLJmWCjHjqmDXiNvdsnohjhQWNF7DoeUdFKtlO9wO mpizjvvCN5MBYtOuKtAEMsXtkfb6rPX7bYT7ZhcpGxUphFm5OcqEWLcib+tuFKBNLN 3CdeBjERt1Fte3q4qIwBZXYt4RGstBgUqvV/ssJU=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab10c37c967a9edf9a91ac604608e380a714fe019792cf00000001180eee8692a169ce16d66007@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2036/review/177781575@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2036@github.com>
References: <quicwg/base-drafts/pull/2036@github.com>
Subject: Re: [quicwg/base-drafts] Rewrite Packet Size section (#2036)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bf72c86e34d9_3bb73faf68ad45c4716770"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/yhmY3sWPTahEqraRpI28vlkOkq4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Nov 2018 22:24:10 -0000

martinthomson commented on this pull request.



> +* An endpoint could store additional information from the IP or UDP headers to
+  use for validation (for example, the IP ID or UDP checksum).
+
+The endpoint SHOULD ignore all ICMP messages that are not validated or do not
+carry sufficient quoted packet payload to perform validation.  Any reduction in
+the QUIC MPS MAY be provisional until QUIC's loss detection algorithm
+determines that the quoted packet has actually been lost.
+
+## Considerations for Datagram Packetization Layer PMTU Discovery
+
+Section 6.4 of {{!DPLPMTUD}} provides considerations for
+implementing Datagram Packetization Layer PMTUD (DPLPMTUD) with QUIC.
+
+When implementing the algorithm in Section 5.3 of
+{{!DPLPMTUD}}, the initial value of BASE_PMTU SHOULD be
+consistent with the minimum QUIC packet size.

The reason I point this out is that the minimum isn't a minimum, it's just the minimum for an Initial packet.  The minimum packet size is something like 21 bytes absent context.  I think that the minimum in this context is probably 1200, which is the lower limit on what servers accept, but then clients don't enforce any such limit.  And of course, probing at 1200 on IPv6 is pointless.

In other words, you do need to be a little more precise.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2036#discussion_r235824683