IETF Logo Mail Archive

Re: [quicwg/base-drafts] Largest Reference algorithm can produce invalid values (#2112)

afrind <notifications@github.com> Tue, 11 December 2018 21:32 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 24A541286E7 for <quic-issues@ietfa.amsl.com>; Tue, 11 Dec 2018 13:32:34 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YoB112fSKMCl for <quic-issues@ietfa.amsl.com>; Tue, 11 Dec 2018 13:32:33 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CE96B127AC2 for <quic-issues@ietf.org>; Tue, 11 Dec 2018 13:32:32 -0800 (PST)
Date: Tue, 11 Dec 2018 13:32:32 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1544563952; bh=vFR2Wa4JVX7V1WjnDwWPBSyS9z9P0F1LYFe6QB8SSoU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=DVqcPwoHuV/skDvaoGe8U691UW3TM6JRmTX0/u2zGgiVLm5w39d+9xYPQSkAjeWKj 2nfde1xwUXfNn9SPGO+p9RPL1xP77I5sSWeKQx1fDPSeZnomyCUHstGU5TWh5OwFhK zgOlVtPLzYr5WTo8+43k3ru9SVNk9sOOOuozEClY=
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab6af92a72b1c0b904e45498b5e5a8d499128f820e92cf000000011827eef092a169ce17393bf8@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2112/446369945@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2112@github.com>
References: <quicwg/base-drafts/issues/2112@github.com>
Subject: Re: [quicwg/base-drafts] Largest Reference algorithm can produce invalid values (#2112)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c102cf0db19_63a13fd53bad45bc80029"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/fpw9upJpxjvjaQAjF6y6E6Dz0RI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Dec 2018 21:32:34 -0000

To get LR=1 on the wire, the original LR had to be 0 (which should have been encoded as 0), or it must be 0 mod 2*MaxEntries.  If TotalNumberOfInserts is 2, then the real LR can only be as large as 12, not 20.  Similarly, LR=18 is outside the valid range when TotalNumberOfInserts is 2.

I think I noticed this once before, but can't remember in which forum I made the comment - perhaps it was on slack.

What does #1904 come up with for these invalid inputs?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2112#issuecomment-446369945

v2.23.0 | Report a Bug | By Email