Re: [quicwg/base-drafts] QPACK [editorial] Update text on wire instructions. (#2938)

Lucas Pardue <notifications@github.com> Wed, 31 July 2019 16:20 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5C9461203DA for <quic-issues@ietfa.amsl.com>; Wed, 31 Jul 2019 09:20:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OOPpPy354WEP for <quic-issues@ietfa.amsl.com>; Wed, 31 Jul 2019 09:20:16 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 63D661203D9 for <quic-issues@ietf.org>; Wed, 31 Jul 2019 09:20:16 -0700 (PDT)
Date: Wed, 31 Jul 2019 09:20:15 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1564590015; bh=9VTIMuuKKU+WW83DivjvBLrTeuYNk0BHQ2oflJ0fQZg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SMkurOYbCuvwLYzzuv/d3Ge2Ybxs4qvepwQ4B8W1B+2v6BdbeldrvZR8tWG2Ox+hT Zscsc/y+mcKRQqYAApawmue/msh39uyNf9bvGgaiFDwnisKUFGwVGKcqd2E8clHhQP QxXZmWuMcFKkdeMkqFB9NCVtptE0LLnp7YkZx2ws=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZSLX25YAX5WC2N7SV3J3ZD7EVBNHHBYU3JAU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2938/review/269122918@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2938@github.com>
References: <quicwg/base-drafts/pull/2938@github.com>
Subject: Re: [quicwg/base-drafts] QPACK [editorial] Update text on wire instructions. (#2938)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d41bfbf70eea_6bcc3ff6d5ecd9643519b4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/g4x-knNw2EDSxM5dd7ksyeOvfGI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Jul 2019 16:20:18 -0000

LPardue commented on this pull request.

I think these changes are good. They address an editorial annoyance I had but never got around to suggesting a fix. 

Alan may have something to say about the change to Represetnation, because that was introduced fairly recently. 

> @@ -170,13 +170,13 @@ decoder and vice versa.
 
 An encoder converts a header list into a header block by emitting either an
 indexed or a literal representation for each header field in the list (see
-{{header-block-representations}}).  Indexed representations achieve high
-compression by replacing the literal name and possibly the value with an index
-to either the static or dynamic table.  References to the static table and
-literal representations do not require any dynamic state and never risk
-head-of-line blocking.  References to the dynamic table risk head-of-line
-blocking if the encoder has not received an acknowledgement indicating the entry
-is available at the decoder.
+{{header-blocks}}).  Indexed representations achieve high compression by

`header-blocks` is a dangling  reference , causing the build failure

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2938#pullrequestreview-269122918