Re: [quicwg/base-drafts] Explicitly talk about Largest Reference zero. (#2251)

Bence Béky <notifications@github.com> Mon, 24 December 2018 14:44 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 686F1130DC3 for <quic-issues@ietfa.amsl.com>; Mon, 24 Dec 2018 06:44:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.086
X-Spam-Level:
X-Spam-Status: No, score=-7.086 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.979, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tZYn_I5JB3Ut for <quic-issues@ietfa.amsl.com>; Mon, 24 Dec 2018 06:44:26 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F22BA130F02 for <quic-issues@ietf.org>; Mon, 24 Dec 2018 06:44:25 -0800 (PST)
Date: Mon, 24 Dec 2018 06:44:24 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545662664; bh=Vo55mfwewMbLXGmoQH8RlsTOekUXbWD87mh0UyzgcIM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=xQ0ihRosK6AQ+NSQCPqeoQ553xF6Ck6mPMWjPnFamQBFiOJMhxf9AoO015dHVnxVY xXzd1KGjr+TrGOR3k7VLdkOv9NIEsvcJ4RN4af8VQG2Kf/idqLJGrRTx/zl74tx/mg cT3S7sz1Btanhep9G1ViD1r77fIB6PaOfN2fJvIA=
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab9688c4897976a3361995760ca788bd77fad401ea92cf000000011838b2c892a169ce1778a020@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2251/review/187705085@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2251@github.com>
References: <quicwg/base-drafts/pull/2251@github.com>
Subject: Re: [quicwg/base-drafts] Explicitly talk about Largest Reference zero. (#2251)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c20f0c8b5181_6bce3f9bbdad45c4768271"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hYQ2W4ipgMVp2sYNYazfLuDtuY4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Dec 2018 14:44:29 -0000

bencebeky commented on this pull request.



> @@ -874,8 +876,7 @@ Largest Reference and Base Index to the same value.  In such case, both the sign
 bit and the Delta Base Index will be set to zero.
 
 A header block that does not reference the dynamic table can use any value for
-Base Index; setting both Largest Reference and Base Index to zero is the most

I think the word "can" is misleading in your sentence "You can encode a Largest Reference of zero", because whether the encoded Largest Reference is zero is not a choice.  I have the same problem with the current wording of the spec, that's exactly why I'm proposing this change.

In my mind, 0 for the abstract notion means that there are no references.  (Is this what you mean by "sentinel value"?)  The spec already calls this out at least in one place, and I'm proposing more clarifications at issue #2251.

In my mind, 0 on the wire does not mean anything.  It has to be decoded.  It just happens so that 0 is mapped to 0, and it just happens to that the current wording of the spec is that 0 is not transcribed, but what that actually means is that 0 is transcribed to 0.

In any case, we having this discussion here is an indication that the text needs some kind of improvement.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2251#discussion_r243835296