Re: [quicwg/base-drafts] Explicitly talk about Largest Reference zero. (#2251)

Bence Béky <notifications@github.com> Sun, 23 December 2018 21:21 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7057E126CC7 for <quic-issues@ietfa.amsl.com>; Sun, 23 Dec 2018 13:21:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.682
X-Spam-Level:
X-Spam-Status: No, score=-5.682 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.979, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nQC-whkS-N0g for <quic-issues@ietfa.amsl.com>; Sun, 23 Dec 2018 13:21:06 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 16468127AC2 for <quic-issues@ietf.org>; Sun, 23 Dec 2018 13:21:06 -0800 (PST)
Date: Sun, 23 Dec 2018 13:21:05 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545600065; bh=3tS4rTW/8sL0kV1y9sWQRwNoxKUD00LTTFBRlON0rI8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=XVLMLLgmwOcCHKkodoHuMcBaX/7KhJlAjXSwATikqFMXwwpxQcbXCTDsf/XyaPMMp TysinUHEic32wMmfy9wesP0K986khO1TOYU+YodjOSeno4TfGYCvfjP6fEJIpkdSFk 3pdecrYK79+1JxAhye/eBXvCeE+JRxKfl622jzE4=
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abfd82ca89cbaecb811a52b7bb7b11f16379333fac92cf000000011837be4192a169ce1778a020@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2251/review/187632892@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2251@github.com>
References: <quicwg/base-drafts/pull/2251@github.com>
Subject: Re: [quicwg/base-drafts] Explicitly talk about Largest Reference zero. (#2251)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1ffc4147461_18333fe8470d45c011706"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/rViH8xRenY6zEQzIsc3kWVNPzPM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Dec 2018 21:21:07 -0000

bencebeky commented on this pull request.



> @@ -874,8 +876,7 @@ Largest Reference and Base Index to the same value.  In such case, both the sign
 bit and the Delta Base Index will be set to zero.
 
 A header block that does not reference the dynamic table can use any value for
-Base Index; setting both Largest Reference and Base Index to zero is the most

I propose removing "Largest Reference" from this sentence because setting it to zero is not a choice.

Optionally one can start the paragraph by "A header block that does not reference the dynamic table MUST use zero for Largest Reference but can use any value...".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2251#pullrequestreview-187632892