Re: [quicwg/base-drafts] HTTP/3 references QUIC Stream IDs directly, allowing illegal references (#3273)

ianswett <notifications@github.com> Wed, 27 November 2019 05:36 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F210D12006D for <quic-issues@ietfa.amsl.com>; Tue, 26 Nov 2019 21:36:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uX1krXhUWrgj for <quic-issues@ietfa.amsl.com>; Tue, 26 Nov 2019 21:36:34 -0800 (PST)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D646F12000F for <quic-issues@ietf.org>; Tue, 26 Nov 2019 21:36:33 -0800 (PST)
Date: Tue, 26 Nov 2019 21:36:32 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1574832993; bh=tdYjXgaVTBX8+68/0k9b7YDKA4iJsHS0iqxPJ3+XmTw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=sQorU8sK59FkqOI3JlL+xJpNIAa/Ns0NSnPfvi/4pz1H9AiFuCfFXkXpG0CNVP4cj gK6a9q7Tm/Ku8FvY3rJWDll2BUpSybN9wP7xRsbTEjZbBt/iwYsrpumtha3r7uONWj Sk64c9Op3SQ5RKzAE8M4fjM6MqS18m3NaTJWfwvQ=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5FU5EJVMMAPOJ2D7535M66BEVBNHHB64UA7U@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3273/558937211@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3273@github.com>
References: <quicwg/base-drafts/issues/3273@github.com>
Subject: Re: [quicwg/base-drafts] HTTP/3 references QUIC Stream IDs directly, allowing illegal references (#3273)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dde0b60eb5f3_14973fb60eccd964450116"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/iLcEgChP3m4KbDuhM4Pb5t8-vGY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Nov 2019 05:36:36 -0000

This seems a bit at odd with our design principles, since it requires the HTTP/3 implementation to understand the QUIC Stream ID numbering scheme.   In our implementation that's viable and it probably is in others.  The current text says:
  "A client MUST treat receipt of a GOAWAY
   frame containing a Stream ID of any other type as a connection error
   of type H3_ID_ERROR."

I don't remember us discussing this particular detail of GOAWAY in Cupertino, but I also wasn't very invested in the GOAWAY discussion, so I believe I missed it.

To be clear, the Request ID -> Stream ID mapping is multiplying by 4 in this case.  There is no state required.

TLDR: This seems weird, but I'm ok with closing with no action if others don't care to fix the oddity.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3273#issuecomment-558937211